-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: infite loop in some demo when deploy #961
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TinyMCE 5 & 6 work perfect!
The block still happens on CKEditor4, not on the 5 though.
thanks, fixed! |
taskid #45069
Would be interesting to complement your changes with a removal of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested all HTML demos, and didn't find any issues! Do we know why these 3 and not the other editors ? It makes sense to change froala, generic, ck5, and the viewer to this new config ? Great job!
Good question! The core error in the problem was that the dist folder was repeatedly written and mixed in when building and packaging the project, including some problematic files (For example, we need some code from Tiny to run Tiny editor in our demo). So, the generic and viewer components didn't need any changes. They shouldn't have used any third-party assets from the beginning. The architecture of CKEditor 5 and CKEditor 4 is completely different. So, for some unknown reason, we didn't need to include CK5 files in the dist folder to run the editor. Froala is most likely to encounter a similar problem because it also packages the entire editor. However, fortunately, it didn't cause any errors. Of course, if the goal is to maintain cleanliness, Froala should be cleanable as well. |
Description
With the current webpack configuration, when deploying demos, the entire editor gets copied over, including some unnecessary files. Due to caching mechanisms, webpack continuously detects changes in the source files of the TinyMCE editor, triggering continuous hot reloads.
This change will exclude those mentioned files during deployment, retaining only the minified or required files as they are the ones actually needed.
Steps to reproduce
dist
directories of all demos. (For example, executegit clean -dfx
)Changes.md
fix: Exclude certain unnecessary files that are copied over during the deployment of TinyMCE 5 & TinyMCE 6 & CKEditor 4 demos to prevent an infinite loop. #KB-44423
#taskid 44423