Update a11y-no-noninteractive-tabindex rule for dev tool bar (#10750)

* fix: a11y-no-noninteractive-tabindex * add changeset
withastro · Apr 11, 2024 · 7e82560 · 7e82560
1 parent e8683d9
commit 7e82560
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/.changeset/few-mails-kiss.md b/.changeset/few-mails-kiss.md
@@ -0,0 +1,5 @@
+---
+"astro": patch
+---
+
+Fixes a false positive for "Invalid `tabindex` on non-interactive element" rule for roleless elements ( `div` and `span` ).
diff --git a/packages/astro/src/runtime/client/dev-toolbar/apps/audit/rules/a11y.ts b/packages/astro/src/runtime/client/dev-toolbar/apps/audit/rules/a11y.ts
@@ -513,7 +513,11 @@ export const a11y: AuditRuleWithSelector[] = [
 
 			if (!isInteractive(element)) return false;
 
-			if (!interactiveElements.includes(element.localName)) return true;
+			if (
+				!interactiveElements.includes(element.localName) &&
+				!roleless_elements.includes(element.localName)
+			)
+				return true;
 		},
 	},
 	{