fix: respect 'mode' CLI flag when running dev command

withastro · Apr 24, 2024 · a987a1f · a987a1f
1 parent fc097e8
commit a987a1f
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 1 deletion.
diff --git a/.changeset/nine-buttons-push.md b/.changeset/nine-buttons-push.md
@@ -0,0 +1,5 @@
+---
+"astro": patch
+---
+
+respect "mode" CLI flag when running dev command
diff --git a/packages/astro/src/core/dev/container.ts b/packages/astro/src/core/dev/container.ts
@@ -68,7 +68,7 @@ export async function createContainer({
 
 	const viteConfig = await createVite(
 		{
-			mode: 'development',
+			mode: inlineConfig?.mode || 'development',
 			server: { host, headers, open },
 			optimizeDeps: {
 				include: rendererClientEntries,

diff --git a/packages/astro/test/units/dev/dev.test.js b/packages/astro/test/units/dev/dev.test.js
@@ -273,4 +273,16 @@ describe('dev container', () => {
 			assert.equal(r.res.statusCode, 200);
 		});
 	});
+
+	it('overrides mode when CLI flag is specified', async () => {
+		await runInContainer({ inlineConfig: { mode: 'staging' } }, (container) => {
+			assert.equal(container.viteServer.config.mode, 'staging');
+		});
+	});
+
+	it('uses "development" mode when CLI flag is not specified', async () => {
+		await runInContainer({}, (container) => {
+			assert.equal(container.viteServer.config.mode, 'development');
+		});
+	});
 });