Skip to content

Commit ec71f03

Browse files
authoredJan 2, 2024
Remove telemetry for unhandled errors (#9571)
1 parent f192fc3 commit ec71f03

File tree

2 files changed

+10
-2
lines changed

2 files changed

+10
-2
lines changed
 

‎.changeset/few-days-relate.md

+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"astro": patch
3+
---
4+
5+
Removes telemetry for unhandled errors in the dev server

‎packages/astro/src/vite-plugin-astro-server/error.ts

+5-2
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ import type { AstroConfig } from '../@types/astro.js';
33
import type DevPipeline from './devPipeline.js';
44

55
import { collectErrorMetadata } from '../core/errors/dev/index.js';
6-
import { createSafeError } from '../core/errors/index.js';
6+
import { createSafeError, AstroErrorData } from '../core/errors/index.js';
77
import { formatErrorMessage } from '../core/messages.js';
88
import { eventError, telemetry } from '../events/index.js';
99

@@ -24,7 +24,10 @@ export function recordServerError(
2424
// Our error should already be complete, but let's try to add a bit more through some guesswork
2525
const errorWithMetadata = collectErrorMetadata(err, config.root);
2626

27-
telemetry.record(eventError({ cmd: 'dev', err: errorWithMetadata, isFatal: false }));
27+
// Ignore unhandled rejection errors as they appear A LOT and we cannot record the amount to telemetry
28+
if (errorWithMetadata.name !== AstroErrorData.UnhandledRejection.name) {
29+
telemetry.record(eventError({ cmd: 'dev', err: errorWithMetadata, isFatal: false }));
30+
}
2831

2932
pipeline.logger.error(
3033
null,

0 commit comments

Comments
 (0)
Please sign in to comment.