Remove telemetry for unhandled errors #9571
Conversation
🦋 Changeset detectedLatest commit: d112bde The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
| @@ -24,7 +24,10 @@ export function recordServerError( | |||
| // Our error should already be complete, but let's try to add a bit more through some guesswork | |||
| const errorWithMetadata = collectErrorMetadata(err, config.root); | |||
|
|
|||
| telemetry.record(eventError({ cmd: 'dev', err: errorWithMetadata, isFatal: false })); | |||
| // Ignore unhandled rejection errors as they appear A LOT and we cannot record the amount to telemetry | |||
| if (errorWithMetadata.name !== AstroErrorData.UnhandledRejection.name) { | |||
There was a problem hiding this comment.
I don't remember, do we need to be defensive against the error not having a name here?
There was a problem hiding this comment.
If it doesn't have a name it should follow through to telemetry, shouldn't it? We would only need to be defensive if the error was null or undefined, which seems unlikely.
There was a problem hiding this comment.
Oh yeah, for sure. I was just wondering if it can be undefined at all there or not
|
I think Fred has the data if we filter the errors by |
Changes
The telemetry for unhandled errors are a LOT, so removing them for now. I didn't uncomment it out as I don't quite see another way we could enable it in the future.
Testing
It's a one-line removal, so should still work like before.
Docs
n/a. not docs related.