-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix preact compat support for libraries (#4213)
Co-authored-by: Matthew Phillips <matthew@skypack.dev>
- Loading branch information
Showing
12 changed files
with
148 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| 'astro': patch | ||
| --- | ||
|
|
||
| Bump Vite to 3.0.5 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@astrojs/preact': patch | ||
| --- | ||
|
|
||
| Fix compat support for libraries |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 changes: 7 additions & 0 deletions
7
packages/astro/test/fixtures/preact-compat-component/astro.config.mjs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| import { defineConfig } from 'astro/config'; | ||
| import preact from '@astrojs/preact'; | ||
|
|
||
| // https://astro.build/config | ||
| export default defineConfig({ | ||
| integrations: [preact({ compat: true })], | ||
| }); |
11 changes: 11 additions & 0 deletions
11
packages/astro/test/fixtures/preact-compat-component/package.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| { | ||
| "name": "@test/preact-compat-component", | ||
| "version": "0.0.0", | ||
| "private": true, | ||
| "dependencies": { | ||
| "@astrojs/preact": "workspace:*", | ||
| "@test/react-lib": "workspace:*", | ||
| "astro": "workspace:*", | ||
| "preact": "^10.10.1" | ||
| } | ||
| } |
5 changes: 5 additions & 0 deletions
5
packages/astro/test/fixtures/preact-compat-component/packages/react-lib/index.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| import { useState } from "react"; | ||
|
|
||
| export function useSpecialState(initialState) { | ||
| return useState(initialState); | ||
| } |
9 changes: 9 additions & 0 deletions
9
packages/astro/test/fixtures/preact-compat-component/packages/react-lib/package.json
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
| { | ||
| "name": "@test/react-lib", | ||
| "version": "0.0.0", | ||
| "private": true, | ||
| "type": "module", | ||
| "dependencies": { | ||
| "react": "^18.2.0" | ||
| } | ||
| } |
19 changes: 19 additions & 0 deletions
19
packages/astro/test/fixtures/preact-compat-component/src/components/Counter.jsx
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| /** @jsxImportSource preact */ | ||
| import { useSpecialState } from '@test/react-lib' | ||
|
|
||
| export default function Counter({ children }) { | ||
| const [count, setCount] = useSpecialState(0); | ||
| const add = () => setCount((i) => i + 1); | ||
| const subtract = () => setCount((i) => i - 1); | ||
|
|
||
| return ( | ||
| <> | ||
| <div class="counter"> | ||
| <button onClick={subtract}>-</button> | ||
| <pre id="counter-text">{count}</pre> | ||
| <button onClick={add}>+</button> | ||
| </div> | ||
| <div class="counter-message">{children}</div> | ||
| </> | ||
| ); | ||
| } |
12 changes: 12 additions & 0 deletions
12
packages/astro/test/fixtures/preact-compat-component/src/pages/index.astro
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| --- | ||
| import Counter from '../components/Counter.jsx'; | ||
| --- | ||
|
|
||
| <html> | ||
| <head> | ||
| <title>Preact compat component</title> | ||
| </head> | ||
| <body> | ||
| <Counter client:load /> | ||
| </body> | ||
| </html> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import { expect } from 'chai'; | ||
| import * as cheerio from 'cheerio'; | ||
| import { loadFixture } from './test-utils.js'; | ||
|
|
||
| describe('Preact compat component', () => { | ||
| describe('Development', () => { | ||
| let fixture; | ||
|
|
||
| before(async () => { | ||
| fixture = await loadFixture({ | ||
| root: './fixtures/preact-compat-component/', | ||
| }); | ||
| await fixture.startDevServer(); | ||
| }); | ||
|
|
||
| it('Can load Counter', async () => { | ||
| const html = await fixture.fetch('/').then((res) => res.text()); | ||
| const $ = cheerio.load(html); | ||
|
|
||
| expect($('#counter-text').text()).to.be.eq('0'); | ||
| }); | ||
| }); | ||
|
|
||
| describe('Build', () => { | ||
| let fixture; | ||
|
|
||
| before(async () => { | ||
| fixture = await loadFixture({ | ||
| root: './fixtures/preact-compat-component/', | ||
| }); | ||
| await fixture.build(); | ||
| }); | ||
|
|
||
| it('Can load Counter', async () => { | ||
| const html = await fixture.readFile('/index.html'); | ||
| const $ = cheerio.load(html); | ||
|
|
||
| expect($('#counter-text').text()).to.be.eq('0'); | ||
| }); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.