Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(@astrojs/vercel): migrate tests to node:test #10010

Merged
merged 2 commits into from Feb 13, 2024
Merged

chore(@astrojs/vercel): migrate tests to node:test #10010

merged 2 commits into from Feb 13, 2024

Conversation

mingjunlu
Copy link
Contributor

@mingjunlu mingjunlu commented Feb 7, 2024 •
edited

Changes

Testing

  • pnpm --filter @astrojs/vercel run test

Docs

  • No docs added since this PR only deals with tests

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 7, 2024 •
edited

⚠️ No Changeset found

Latest commit: 465667d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: integration Related to any renderer integration (scope) label Feb 7, 2024
@mingjunlu mingjunlu force-pushed the astrojs-vercel-test-migration branch from 21bbe89 to f1aa13a Compare February 7, 2024 09:03
@mingjunlu mingjunlu marked this pull request as ready for review February 7, 2024 09:26
@mingjunlu mingjunlu force-pushed the astrojs-vercel-test-migration branch 3 times, most recently from f1aa13a to 61d0545 Compare February 12, 2024 08:34
ematipico
ematipico approved these changes Feb 13, 2024
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove mocha and chai from the dependencies and update the lock file?

@mingjunlu
Copy link
Contributor Author

mingjunlu commented Feb 13, 2024 •
edited

Can you remove mocha and chai from the dependencies and update the lock file?

@ematipico Sure, but edge-middleware.test.js would be left out of testing. Is that alright?

Background: That test file contains snapshot testing, but Node.js doesn't support it for now

@ematipico
Copy link
Member

Sorry I didn't read that you didn't move all the files

@mingjunlu
Copy link
Contributor Author

mingjunlu commented Feb 13, 2024 •
edited

No problem! I just noticed that the two test cases using snapshot were already skipped.

I guess it's fine to migrate that file now?

@ematipico ematipico merged commit 37c7510 into withastro:main Feb 13, 2024
25 of 26 checks passed
@mingjunlu mingjunlu deleted the astrojs-vercel-test-migration branch February 14, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico ematipico approved these changes

Assignees
No one assigned
Labels
pkg: integration Related to any renderer integration (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mingjunlu @ematipico