Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the message of MiddlewareCantBeLoaded for clarity #10239

Merged

Conversation

mingjunlu
Copy link
Contributor

@mingjunlu mingjunlu commented Feb 27, 2024

Changes

  • Updates the message of MiddlewareCantBeLoaded

    Before After
    The middleware threw an error while Astro was trying to loading it. An unknown error was thrown while loading your middleware.

Testing

  • No tests added. Current tests should pass

Docs

  • Error reference on the docs seems to be auto-generated

Copy link

changeset-bot bot commented Feb 27, 2024

🦋 Changeset detected

Latest commit: eb29f48

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs pr A PR that includes documentation for review labels Feb 27, 2024
@ematipico ematipico merged commit 9c21a9d into withastro:main Feb 27, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request Feb 27, 2024
@mingjunlu mingjunlu deleted the improve-middleware-cant-be-loaded-message branch February 27, 2024 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs pr A PR that includes documentation for review pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants