Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): hardcoded supported Node.js version #10742

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix(cli): hardcoded supported Node.js version #10742

wants to merge 1 commit into from
+1 −1

Conversation

ematipico
Copy link
Member

Changes

Follow up of the PR that updated the defined engines inside our package.json files

Testing

N/A

Docs

N/A

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 10, 2024

⚠️ No Changeset found

Latest commit: f0c79b8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Apr 10, 2024
bluwy
bluwy previously approved these changes Apr 10, 2024
View reviewed changes
@bluwy bluwy dismissed their stale review April 10, 2024 14:19

Only in Astro 5

@Princesseuh Princesseuh added the semver: major Change triggers a `major` release label Apr 10, 2024
Princesseuh
Princesseuh requested changes Apr 10, 2024
View reviewed changes
Copy link
Member

@Princesseuh Princesseuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only do this for Astro 5! This is super breaking otherwise.

@ematipico
Copy link
Member Author

Ooops, sorry 😆 I misunderstood that

@ematipico ematipico marked this pull request as draft April 10, 2024 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Princesseuh Princesseuh Princesseuh requested changes

@bluwy bluwy bluwy left review comments

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) semver: major Change triggers a `major` release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ematipico @Princesseuh @bluwy