feat(env): server/secret variables #10954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
florian-lefebvre
commented
May 7, 2024
bholmesdev
reviewed
May 7, 2024
bholmesdev
approved these changes
May 7, 2024
ematipico
reviewed
May 8, 2024
| @@ -2428,6 +2428,11 @@ export type AstroFeatureMap = { | |||
| * List of features that orbit around the i18n routing | |||
| */ | |||
| i18nDomains?: SupportsKind; | |||
|
|
|||
| /** | |||
| * The adapter is able to support `astro:env` | |||
There was a problem hiding this comment.
We might want to be more specific. It's not a blocker, however the support is for getEnv, right?
There was a problem hiding this comment.
Yes, it means if the adapter has a custom getEnv. It defaults to process.env, happy to change the name if you have better ideas!
There was a problem hiding this comment.
envGetter? Even env is fine, as long as we're good at documenting it
There was a problem hiding this comment.
Will spend some time working on jsdoc in the last pr 👍
bluwy
reviewed
May 8, 2024
ematipico
approved these changes
May 8, 2024
| @@ -2428,6 +2428,11 @@ export type AstroFeatureMap = { | |||
| * List of features that orbit around the i18n routing | |||
| */ | |||
| i18nDomains?: SupportsKind; | |||
|
|
|||
| /** | |||
| * The adapter is able to support `astro:env` | |||
There was a problem hiding this comment.
envGetter? Even env is fine, as long as we're good at documenting it
bluwy
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
getEnvtoRenderContextTesting
Cleans a test i forgot and add one to test
getSecretwith thetestAdapterDocs
N/A