Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: allow locals access from actions #11006

Merged
merged 3 commits into from
May 13, 2024
Merged

Conversation

bholmesdev
Copy link
Contributor

Changes

Move actions middleware to run after user middleware for locals access. This should unblock authwentication middleware for action handlers.

Testing

Add integration test with user middleware.

Docs

N/A: this feature is expected in the RFC already.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

changeset-bot bot commented May 10, 2024

🦋 Changeset detected

Latest commit: 05fecc9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 10, 2024
@bholmesdev bholmesdev merged commit 7418bb0 into main May 13, 2024
13 checks passed
@bholmesdev bholmesdev deleted the fix/actions-middleware-order branch May 13, 2024 11:23
@astrobot-houston astrobot-houston mentioned this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants