fix: better isPromise check for proxy objects #11178
Merged
+6
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: bc851c9 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
bluwy
approved these changes
Jun 4, 2024
.changeset/green-moose-fetch.md
Outdated
| 'astro': patch | ||
| --- | ||
|
|
||
| fix: make isPromise work on proxy objects |
There was a problem hiding this comment.
Suggested change
| fix: make isPromise work on proxy objects | |
| Fixes a case where a `Promise` on a `Proxy` would not be handled correctly |
I'm not sure about the wording "on a" mainly because idk much about proxies. Any suggestions?
There was a problem hiding this comment.
How about
Improves `isPromise` utility to check the presence of `then` on an object before trying to access it - which can cause undesired side-effects on Proxy objects
theoephraim
force-pushed
the
is-promise-proxy-bug
branch
from
b7b1cb3 to
6095471
Compare
theoephraim
force-pushed
the
is-promise-proxy-bug
branch
from
6095471 to
bc851c9
Compare
florian-lefebvre
approved these changes
Jun 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adjusts the
isPromiseutility to first check for the presence of the'then'key before accessing it to check the type.The absence of this check on a Proxy object was causing an error to be thrown - as my Proxy object throws on access of an unknown keys.
Testing
This should be a totally transparent change, and not quite worth setting up a test IMO.
Note that a few tests were failing for me locally, but they are failing on main as well, so seem to be unrelated.
Docs
N/A - This should hopefully be a totally transparent change that affects nothing other than this very specific error scenario.