Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(astro): getSecret in dev and build #11198

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented Jun 6, 2024

Changes

  • process.env was not populated

Testing

Added a test

Docs

N/A

Copy link

changeset-bot bot commented Jun 6, 2024

🦋 Changeset detected

Latest commit: 7ebe7fc

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 6, 2024
@matthewp
Copy link
Contributor

matthewp commented Jun 6, 2024

Would still like a test for this, seems like you could have a fixture that has a .env file and you read the secret in a page and place the value in the HTML somewhere.

@florian-lefebvre
Copy link
Member Author

I added a test

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just spotted a tiny typo.

Co-authored-by: Paul Valladares <85648028+dreyfus92@users.noreply.github.com>
@florian-lefebvre florian-lefebvre merged commit 8b9a499 into main Jun 6, 2024
13 checks passed
@florian-lefebvre florian-lefebvre deleted the fix/astro-env-default-get-secret branch June 6, 2024 20:19
@astrobot-houston astrobot-houston mentioned this pull request Jun 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants