fix(rewrite): purge old data when rewriting #11207
Merged
+168
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 025a2ce The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
matthewp
reviewed
Jun 7, 2024
matthewp
reviewed
Jun 7, 2024
sarah11918
reviewed
Jun 10, 2024
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
sarah11918
approved these changes
Jun 10, 2024
matthewp
approved these changes
Jun 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Closes #11204
This PR fixes two issues:
RenderContext,pathnameis now updated during the rewriting. To correctly infer the correct pathname (RouteData.pathamesometimes is undefined, andRouteData.routeins't correct e.g./some-slug/titleVS/[slug]/title, and we need the former)tryRewritenow returns the newURL, since we had the logic here in all the pipelinesAstroPartialobject when rewriting because during rewriting, we were sending old information, such asparamsTesting
Added two new test cases
Docs
N/A