Fix VITE_ASSET bug #3439
Merged
Fix VITE_ASSET bug #3439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3efcc62 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
tony-sull
approved these changes
May 25, 2022
natemoo-re
reviewed
May 25, 2022
Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Merged
Closed
1 task
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* Fix VITE_ASSET bug * Updated test that depended on esbuild output * Fix some more tests * Fix css config and postcss tests * Git client only working * Fix static build test * Update tailwind tests * Fix build * Fix css bundling tests * Updated some more tests for windows * Remove tests that are no longer relevant * Cause it to break * Fix bug and add explanation * Adds a changeset * Inline comments about what the hashing is doing * Update packages/astro/src/vite-plugin-build-css/index.ts Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com> * Update to the lockfile * Minify css * Update tailwind tests Co-authored-by: Nate Moore <natemoo-re@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
url()replaced by __VITE_ASSET__* #2146vite:css-postnow which does CSS bundling and updating of JS.manualChunksto create chunks for CSS. The algorithm walks a CSS file until it finds its parents and creates a hash from that. This means that if CSS is shared on multiple pages it will be combined into a shared chunk.css-postplugin will correctly remove them. I'll submit an upstream PR to fix that.Testing
vite:css-postthis happens in a different way and the output is not different.astro-css-bundling-import) because it depends on ordering that we no longer control, so it was removed.Docs
N/A, bug fix.