Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor Vite's importMeta.d.ts inside our repo to workaround issue with tsc on Linux #4499

Merged
merged 4 commits into from
Aug 26, 2022

Conversation

Princesseuh
Copy link
Member

Changes

tsc doesn't handle paths with uppercase characters inside tripleslash directives using types correctly. The TypeScript team is aware of this, but it's been an issue for years now. Renaming the file to use lower case characters works, however this is understandably a breaking change for the Vite team (see vitejs/vite#9827)

As such, for now we'll just copy the file in our own repository until Vite 4 comes out. That's okay

Fix #4387

Testing

Tested manually

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2022

🦋 Changeset detected

Latest commit: 92f78fb

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Aug 26, 2022
@Princesseuh Princesseuh merged commit 1f42c07 into main Aug 26, 2022
@Princesseuh Princesseuh deleted the workaround-linux-vite-types branch August 26, 2022 15:47
@astrobot-houston astrobot-houston mentioned this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typescript type check fails on linux
2 participants