Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Content collections] Remove experimental flag #5825

Merged
merged 7 commits into from Jan 11, 2023

Conversation

bholmesdev
Copy link
Contributor

@bholmesdev bholmesdev commented Jan 10, 2023

Changes

  • Removes experimental.contentCollections flag

Testing

  • Remove flag wherever used

Docs

withastro/docs#2354

@changeset-bot
Copy link

changeset-bot bot commented Jan 10, 2023

🦋 Changeset detected

Latest commit: b470255

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope) feat: markdown Related to Markdown (scope) labels Jan 10, 2023
@bholmesdev bholmesdev marked this pull request as ready for review January 11, 2023 16:48
@bholmesdev bholmesdev requested a review from a team as a code owner January 11, 2023 16:48
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a question about disallowing relative assets with this setup!

packages/integrations/mdx/src/plugins.ts Show resolved Hide resolved
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm content with this change.

@bholmesdev bholmesdev merged commit 52209ca into main Jan 11, 2023
@bholmesdev bholmesdev deleted the feat/remove-content-collections-experimental-flag branch January 11, 2023 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants