Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: improve CONTRIBUTING.md #6867

Merged
merged 3 commits into from Apr 18, 2023
Merged

docs: improve CONTRIBUTING.md #6867

merged 3 commits into from Apr 18, 2023

Conversation

nix6839
Copy link
Contributor

@nix6839 nix6839 commented Apr 17, 2023 •
edited

Changes

  • Update prerequisite to latest information (See: Update to pnpm 8 #6823 and Drop Node 14 support #5782).
  • Fix typo.
  • Add language for code blocks.
  • Add angle brackets around the bare URLs.
  • Update changesets repository URL.
  • Fix invalid links.
  • Improve grammar.

Testing

Only document has changed.

Docs

@changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2023 •
edited

⚠️ No Changeset found

Latest commit: eaf4551

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

bluwy
bluwy reviewed Apr 18, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@bluwy bluwy requested a review from a team April 18, 2023 05:58
ElianCodes
ElianCodes reviewed Apr 18, 2023
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
CONTRIBUTING.md Outdated Show resolved Hide resolved
@nix6839 @ElianCodes
docs: apply suggestions from code review
93014b6 
Co-authored-by: Elian ☕️ <hello@elian.codes>
yanthomasdev
yanthomasdev approved these changes Apr 18, 2023
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nix6839, LGTM!

sarah11918
sarah11918 reviewed Apr 18, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs approves the changes!

@bluwy bluwy merged commit dec072f into withastro:main Apr 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 left review comments

@yanthomasdev yanthomasdev yanthomasdev approved these changes

@bluwy bluwy bluwy approved these changes

@ElianCodes ElianCodes Awaiting requested review from ElianCodes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nix6839 @sarah11918 @ElianCodes @bluwy @yanthomasdev