Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vite-plugin-content-virtual-mod run getEntrySlug 10 at a time #7125

Merged
merged 4 commits into from May 23, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented May 19, 2023

Changes

Fix #7073

Make vite-plugin-content-virtual-mod run getEntrySlug serially as it reads the filesystem. Running in parallel all at once could cause the OS to lock reading files.

Testing

Manually tested with docs to see if there's a first-page load slowdown. I didn't notice a big difference so this should be good.

Docs

n/a. bug fix.

@changeset-bot
Copy link

changeset-bot bot commented May 19, 2023

🦋 Changeset detected

Latest commit: 3d09c0c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 19, 2023
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good. Should we make a preview release and ask users to test it to make sure that this is the correct fix?

@bluwy
Copy link
Member Author

bluwy commented May 19, 2023

!preview content-serial

@github-actions
Copy link
Contributor

 > root@0.0.0 release /home/runner/work/astro/astro > pnpm run build && changeset publish "--tag" "next--content-serial" > root@0.0.0 build /home/runner/work/astro/astro > turbo run build --filter=astro --filter=create-astro --filter="@astrojs/*" --filter="@benchmark/*" �[2m• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/deno, @astrojs/image, @astrojs/lit, @astrojs/markdoc, @astrojs/markdown-component, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prefetch, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/turbolinks, @astrojs/vercel, @astrojs/vue, @astrojs/webapi, @benchmark/timer, astro, create-astro�[0m �[2m• Running�[0m �[2m�[1mbuild�[0m�[0m �[2min 29 packages�[0m �[2m• Remote caching enabled�[0m �[35m@astrojs/webapi:build: �[0mcache hit, suppressing output �[2m20bbcfd7581aee94�[0m �[32m@astrojs/prism:build: �[0mcache hit, suppressing output �[2mb5195d1f71d24a12�[0m �[36m@astrojs/telemetry:build: �[0mcache hit, suppressing output �[2mfc1623ba14af6f46�[0m �[33mcreate-astro:build: �[0mcache hit, suppressing output �[2mf1cb8d3a6d5cb11f�[0m �[34m@astrojs/markdown-remark:build: �[0mcache hit, suppressing output �[2m7d883bb205cd5d3f�[0m �[35mastro:build: �[0mcache miss, executing �[2m645e33d2a6a2215b�[0m �[35mastro:build: �[0m �[35mastro:build: �[0m> astro@0.0.0-content-serial-20230519093503 build /home/runner/work/astro/astro/packages/astro �[35mastro:build: �[0m> pnpm run prebuild && astro-scripts build "src/**/*.{ts,js}" && tsc && pnpm run postbuild �[35mastro:build: �[0m �[35mastro:build: �[0m �[35mastro:build: �[0m> astro@0.0.0-content-serial-20230519093503 prebuild /home/runner/work/astro/astro/packages/astro �[35mastro:build: �[0m> astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts" �[35mastro:build: �[0m �[35mastro:build: �[0m �[35mastro:build: �[0m> astro@0.0.0-content-serial-20230519093503 postbuild /home/runner/work/astro/astro/packages/astro �[35mastro:build: �[0m> astro-scripts copy "src/**/*.astro" && astro-scripts copy "src/**/*.wasm" �[35mastro:build: �[0m �[35m@astrojs/partytown:build: �[0mcache miss, executing �[2maa1d572b48705bfd�[0m �[36m@astrojs/cloudflare:build: �[0mcache miss, executing �[2me74f1be774539530�[0m �[35m@astrojs/turbolinks:build: �[0mcache miss, executing �[2m4ee93eadf6225d9a�[0m �[33m@astrojs/node:build: �[0mcache miss, executing �[2m3d6d88a9bc10fe75�[0m �[34m@astrojs/solid-js:build: �[0mcache miss, executing �[2m189c597d7a434c03�[0m �[34m@astrojs/netlify:build: �[0mcache miss, executing �[2ma64f10d902d7d972�[0m �[32m@astrojs/preact:build: �[0mcache miss, executing �[2mba757aafbf627c1a�[0m �[33m@astrojs/prefetch:build: �[0mcache miss, executing �[2ma919579ebc03cbd0�[0m �[32m@astrojs/deno:build: �[0mcache miss, executing �[2mb48b8c05367c3049�[0m �[36m@astrojs/tailwind:build: �[0mcache miss, executing �[2mf9abf888eeaba019�[0m �[33m@astrojs/node:build: �[0m �[33m@astrojs/node:build: �[0m> @astrojs/node@5.1.4 build /home/runner/work/astro/astro/packages/integrations/node �[33m@astrojs/node:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/node:build: �[0m �[36m@astrojs/cloudflare:build: �[0m �[36m@astrojs/cloudflare:build: �[0m> @astrojs/cloudflare@6.3.0 build /home/runner/work/astro/astro/packages/integrations/cloudflare �[36m@astrojs/cloudflare:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/cloudflare:build: �[0m �[35m@astrojs/turbolinks:build: �[0m �[35m@astrojs/turbolinks:build: �[0m> @astrojs/turbolinks@0.2.2 build /home/runner/work/astro/astro/packages/integrations/turbolinks �[35m@astrojs/turbolinks:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/turbolinks:build: �[0m �[35m@astrojs/partytown:build: �[0m �[35m@astrojs/partytown:build: �[0m> @astrojs/partytown@1.2.2 build /home/runner/work/astro/astro/packages/integrations/partytown �[35m@astrojs/partytown:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/partytown:build: �[0m �[34m@astrojs/netlify:build: �[0m �[34m@astrojs/netlify:build: �[0m> @astrojs/netlify@2.2.3 build /home/runner/work/astro/astro/packages/integrations/netlify �[34m@astrojs/netlify:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/netlify:build: �[0m �[34m@astrojs/solid-js:build: �[0m �[34m@astrojs/solid-js:build: �[0m> @astrojs/solid-js@2.2.0 build /home/runner/work/astro/astro/packages/integrations/solid �[34m@astrojs/solid-js:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/solid-js:build: �[0m �[32m@astrojs/preact:build: �[0m �[32m@astrojs/preact:build: �[0m> @astrojs/preact@2.2.0 build /home/runner/work/astro/astro/packages/integrations/preact �[32m@astrojs/preact:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/preact:build: �[0m �[32m@astrojs/deno:build: �[0m �[32m@astrojs/deno:build: �[0m> @astrojs/deno@4.1.1 build /home/runner/work/astro/astro/packages/integrations/deno �[32m@astrojs/deno:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/deno:build: �[0m �[33m@astrojs/prefetch:build: �[0m �[33m@astrojs/prefetch:build: �[0m> @astrojs/prefetch@0.2.2 build /home/runner/work/astro/astro/packages/integrations/prefetch �[33m@astrojs/prefetch:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/prefetch:build: �[0m �[36m@astrojs/tailwind:build: �[0m �[36m@astrojs/tailwind:build: �[0m> @astrojs/tailwind@3.1.3 build /home/runner/work/astro/astro/packages/integrations/tailwind �[36m@astrojs/tailwind:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/tailwind:build: �[0m �[32m@astrojs/react:build: �[0mcache miss, executing �[2m3d6c66e2a78f5a43�[0m �[33m@astrojs/image:build: �[0mcache miss, executing �[2m8e7c354a62fed8e4�[0m �[34m@astrojs/mdx:build: �[0mcache miss, executing �[2m513f2ae26db6106c�[0m �[36m@astrojs/svelte:build: �[0mcache miss, executing �[2m4a98dcfaec91383c�[0m �[35m@benchmark/timer:build: �[0mcache miss, executing �[2m622b900099e98f1d�[0m �[33m@astrojs/lit:build: �[0mcache miss, executing �[2m686aff8724682e18�[0m �[34m@astrojs/alpinejs:build: �[0mcache miss, executing �[2m31c4f73f5ac9ca1b�[0m �[32m@astrojs/markdoc:build: �[0mcache miss, executing �[2md9fa3180864fd31f�[0m �[32m@astrojs/react:build: �[0m �[32m@astrojs/react:build: �[0m> @astrojs/react@2.2.0 build /home/runner/work/astro/astro/packages/integrations/react �[32m@astrojs/react:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/react:build: �[0m �[36m@astrojs/rss:build: �[0mcache miss, executing �[2m9e4a7f28e0b8473a�[0m �[35m@astrojs/vue:build: �[0mcache miss, executing �[2mf0d4eacbf4612139�[0m �[33m@astrojs/image:build: �[0m �[33m@astrojs/image:build: �[0m> @astrojs/image@0.16.9 build /home/runner/work/astro/astro/packages/integrations/image �[33m@astrojs/image:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/image:build: �[0m �[34m@astrojs/mdx:build: �[0m �[34m@astrojs/mdx:build: �[0m> @astrojs/mdx@0.19.2 build /home/runner/work/astro/astro/packages/integrations/mdx �[34m@astrojs/mdx:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/mdx:build: �[0m �[35m@benchmark/timer:build: �[0m �[35m@benchmark/timer:build: �[0m> @benchmark/timer@0.0.0 build /home/runner/work/astro/astro/benchmark/packages/timer �[35m@benchmark/timer:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@benchmark/timer:build: �[0m �[36m@astrojs/svelte:build: �[0m �[36m@astrojs/svelte:build: �[0m> @astrojs/svelte@2.2.0 build /home/runner/work/astro/astro/packages/integrations/svelte �[36m@astrojs/svelte:build: �[0m> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc �[36m@astrojs/svelte:build: �[0m �[34m@astrojs/alpinejs:build: �[0m �[34m@astrojs/alpinejs:build: �[0m> @astrojs/alpinejs@0.2.2 build /home/runner/work/astro/astro/packages/integrations/alpinejs �[34m@astrojs/alpinejs:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/alpinejs:build: �[0m �[32m@astrojs/markdoc:build: �[0m �[32m@astrojs/markdoc:build: �[0m> @astrojs/markdoc@0.2.0 build /home/runner/work/astro/astro/packages/integrations/markdoc �[32m@astrojs/markdoc:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/markdoc:build: �[0m �[33m@astrojs/lit:build: �[0m �[33m@astrojs/lit:build: �[0m> @astrojs/lit@2.0.2 build /home/runner/work/astro/astro/packages/integrations/lit �[33m@astrojs/lit:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/lit:build: �[0m �[36m@astrojs/rss:build: �[0m �[36m@astrojs/rss:build: �[0m> @astrojs/rss@2.4.2 build /home/runner/work/astro/astro/packages/astro-rss �[36m@astrojs/rss:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/rss:build: �[0m �[35m@astrojs/vue:build: �[0m �[35m@astrojs/vue:build: �[0m> @astrojs/vue@2.2.0 build /home/runner/work/astro/astro/packages/integrations/vue �[35m@astrojs/vue:build: �[0m> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc �[35m@astrojs/vue:build: �[0m �[32m@astrojs/vercel:build: �[0mcache miss, executing �[2m4b183c560885ec3f�[0m �[33m@astrojs/sitemap:build: �[0mcache miss, executing �[2m6ca15e2dc798c61d�[0m �[32m@astrojs/vercel:build: �[0m �[32m@astrojs/vercel:build: �[0m> @astrojs/vercel@3.4.0 build /home/runner/work/astro/astro/packages/integrations/vercel �[32m@astrojs/vercel:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/vercel:build: �[0m �[33m@astrojs/sitemap:build: �[0m �[33m@astrojs/sitemap:build: �[0m> @astrojs/sitemap@1.3.1 build /home/runner/work/astro/astro/packages/integrations/sitemap �[33m@astrojs/sitemap:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/sitemap:build: �[0m Tasks: 28 successful, 28 total Cached: 5 cached, 28 total Time: 1m7.934s 🦋 �[33mwarn�[39m �[31m===============================IMPORTANT!===============================�[39m 🦋 �[33mwarn�[39m Packages will be released under the next--content-serial tag 🦋 �[33mwarn�[39m �[31m----------------------------------------------------------------------�[39m 🦋 �[36minfo�[39m npm info astro 🦋 �[36minfo�[39m npm info @astrojs/prism 🦋 �[36minfo�[39m npm info @astrojs/rss 🦋 �[36minfo�[39m npm info create-astro 🦋 �[36minfo�[39m npm info @astrojs/alpinejs 🦋 �[36minfo�[39m npm info @astrojs/cloudflare 🦋 �[36minfo�[39m npm info @astrojs/deno 🦋 �[36minfo�[39m npm info @astrojs/image 🦋 �[36minfo�[39m npm info @astrojs/lit 🦋 �[36minfo�[39m npm info @astrojs/markdoc 🦋 �[36minfo�[39m npm info @astrojs/mdx 🦋 �[36minfo�[39m npm info @astrojs/netlify 🦋 �[36minfo�[39m npm info @astrojs/node 🦋 �[36minfo�[39m npm info @astrojs/partytown 🦋 �[36minfo�[39m npm info @astrojs/preact 🦋 �[36minfo�[39m npm info @astrojs/prefetch 🦋 �[36minfo�[39m npm info @astrojs/react 🦋 �[36minfo�[39m npm info @astrojs/sitemap 🦋 �[36minfo�[39m npm info @astrojs/solid-js 🦋 �[36minfo�[39m npm info @astrojs/svelte 🦋 �[36minfo�[39m npm info @astrojs/tailwind 🦋 �[36minfo�[39m npm info @astrojs/turbolinks 🦋 �[36minfo�[39m npm info @astrojs/vercel 🦋 �[36minfo�[39m npm info @astrojs/vue 🦋 �[36minfo�[39m npm info @astrojs/markdown-component 🦋 �[36minfo�[39m npm info @astrojs/markdown-remark 🦋 �[36minfo�[39m npm info @astrojs/telemetry 🦋 �[36minfo�[39m npm info @astrojs/webapi 🦋 �[36minfo�[39m astro is being published because our local version (0.0.0-content-serial-20230519093503) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/prism is not being published because version 2.1.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/rss is not being published because version 2.4.2 is already published on npm 🦋 �[33mwarn�[39m create-astro is not being published because version 3.1.5 is already published on npm 🦋 �[33mwarn�[39m @astrojs/alpinejs is not being published because version 0.2.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/cloudflare is not being published because version 6.3.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/deno is not being published because version 4.1.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/image is not being published because version 0.16.9 is already published on npm 🦋 �[33mwarn�[39m @astrojs/lit is not being published because version 2.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdoc is not being published because version 0.2.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/mdx is not being published because version 0.19.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/netlify is not being published because version 2.2.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/node is not being published because version 5.1.4 is already published on npm 🦋 �[33mwarn�[39m @astrojs/partytown is not being published because version 1.2.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/preact is not being published because version 2.2.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/prefetch is not being published because version 0.2.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/react is not being published because version 2.2.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/sitemap is not being published because version 1.3.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/solid-js is not being published because version 2.2.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/svelte is not being published because version 2.2.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/tailwind is not being published because version 3.1.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/turbolinks is not being published because version 0.2.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vercel is not being published because version 3.4.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vue is not being published because version 2.2.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdown-component is not being published because version 1.0.4 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdown-remark is not being published because version 2.2.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/telemetry is not being published because version 2.1.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/webapi is not being published because version 2.1.1 is already published on npm 🦋 �[36minfo�[39m Publishing �[36m"astro"�[39m at �[32m"0.0.0-content-serial-20230519093503"�[39m 🦋 �[32msuccess�[39m packages published successfully: 🦋 astro@0.0.0-content-serial-20230519093503 🦋 Creating git tag... 🦋 New tag: astro@0.0.0-content-serial-20230519093503

@bluwy
Copy link
Member Author

bluwy commented May 22, 2023

!preview content-serial

@github-actions
Copy link
Contributor

 > root@0.0.0 release /home/runner/work/astro/astro > pnpm run build && changeset publish "--tag" "next--content-serial" > root@0.0.0 build /home/runner/work/astro/astro > turbo run build --filter=astro --filter=create-astro --filter="@astrojs/*" --filter="@benchmark/*" �[2m• Packages in scope: @astrojs/alpinejs, @astrojs/cloudflare, @astrojs/deno, @astrojs/image, @astrojs/lit, @astrojs/markdoc, @astrojs/markdown-component, @astrojs/markdown-remark, @astrojs/mdx, @astrojs/netlify, @astrojs/node, @astrojs/partytown, @astrojs/preact, @astrojs/prefetch, @astrojs/prism, @astrojs/react, @astrojs/rss, @astrojs/sitemap, @astrojs/solid-js, @astrojs/svelte, @astrojs/tailwind, @astrojs/telemetry, @astrojs/turbolinks, @astrojs/vercel, @astrojs/vue, @astrojs/webapi, @benchmark/timer, astro, create-astro�[0m �[2m• Running�[0m �[2m�[1mbuild�[0m�[0m �[2min 29 packages�[0m �[2m• Remote caching enabled�[0m �[35m@astrojs/webapi:build: �[0mcache hit, suppressing output �[2m20bbcfd7581aee94�[0m �[32mcreate-astro:build: �[0mcache hit, suppressing output �[2mf1cb8d3a6d5cb11f�[0m �[34m@astrojs/prism:build: �[0mcache hit, suppressing output �[2mb5195d1f71d24a12�[0m �[33m@astrojs/telemetry:build: �[0mcache hit, suppressing output �[2mfc1623ba14af6f46�[0m �[36m@astrojs/markdown-remark:build: �[0mcache hit, suppressing output �[2m7d883bb205cd5d3f�[0m �[35mastro:build: �[0mcache miss, executing �[2m18d1f94f0ce72fd7�[0m �[35mastro:build: �[0m �[35mastro:build: �[0m> astro@0.0.0-content-serial-20230522100058 build /home/runner/work/astro/astro/packages/astro �[35mastro:build: �[0m> pnpm run prebuild && astro-scripts build "src/**/*.{ts,js}" && tsc && pnpm run postbuild �[35mastro:build: �[0m �[35mastro:build: �[0m �[35mastro:build: �[0m> astro@0.0.0-content-serial-20230522100058 prebuild /home/runner/work/astro/astro/packages/astro �[35mastro:build: �[0m> astro-scripts prebuild --to-string "src/runtime/server/astro-island.ts" "src/runtime/client/{idle,load,media,only,visible}.ts" �[35mastro:build: �[0m �[35mastro:build: �[0m �[35mastro:build: �[0m> astro@0.0.0-content-serial-20230522100058 postbuild /home/runner/work/astro/astro/packages/astro �[35mastro:build: �[0m> astro-scripts copy "src/**/*.astro" && astro-scripts copy "src/**/*.wasm" �[35mastro:build: �[0m �[35m@astrojs/turbolinks:build: �[0mcache miss, executing �[2m35ed225b66c49258�[0m �[36m@astrojs/solid-js:build: �[0mcache miss, executing �[2m9e1f6a436ec3160e�[0m �[34m@astrojs/deno:build: �[0mcache miss, executing �[2m9ae2fbacccd08eb4�[0m �[33m@astrojs/lit:build: �[0mcache miss, executing �[2mbb068e1fc7f8d4d1�[0m �[36m@astrojs/image:build: �[0mcache miss, executing �[2m954434d1de36e75f�[0m �[34m@astrojs/react:build: �[0mcache miss, executing �[2m3308cfe5ad413c9c�[0m �[32m@astrojs/cloudflare:build: �[0mcache miss, executing �[2m32a759a900ea6fcb�[0m �[32m@astrojs/rss:build: �[0mcache miss, executing �[2m5c344c00297bd850�[0m �[35m@astrojs/vercel:build: �[0mcache miss, executing �[2mf851910726212e29�[0m �[33m@astrojs/svelte:build: �[0mcache miss, executing �[2ma408bf6034720912�[0m �[35m@astrojs/turbolinks:build: �[0m �[35m@astrojs/turbolinks:build: �[0m> @astrojs/turbolinks@0.2.2 build /home/runner/work/astro/astro/packages/integrations/turbolinks �[35m@astrojs/turbolinks:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/turbolinks:build: �[0m �[34m@astrojs/react:build: �[0m �[34m@astrojs/react:build: �[0m> @astrojs/react@2.2.0 build /home/runner/work/astro/astro/packages/integrations/react �[34m@astrojs/react:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/react:build: �[0m �[36m@astrojs/solid-js:build: �[0m �[36m@astrojs/solid-js:build: �[0m> @astrojs/solid-js@2.2.0 build /home/runner/work/astro/astro/packages/integrations/solid �[36m@astrojs/solid-js:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/solid-js:build: �[0m �[32m@astrojs/rss:build: �[0m �[32m@astrojs/rss:build: �[0m> @astrojs/rss@2.4.2 build /home/runner/work/astro/astro/packages/astro-rss �[32m@astrojs/rss:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/rss:build: �[0m �[36m@astrojs/image:build: �[0m �[36m@astrojs/image:build: �[0m> @astrojs/image@0.16.9 build /home/runner/work/astro/astro/packages/integrations/image �[36m@astrojs/image:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/image:build: �[0m �[33m@astrojs/lit:build: �[0m �[33m@astrojs/lit:build: �[0m> @astrojs/lit@2.0.2 build /home/runner/work/astro/astro/packages/integrations/lit �[33m@astrojs/lit:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/lit:build: �[0m �[34m@astrojs/deno:build: �[0m �[34m@astrojs/deno:build: �[0m> @astrojs/deno@4.1.1 build /home/runner/work/astro/astro/packages/integrations/deno �[34m@astrojs/deno:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/deno:build: �[0m �[32m@astrojs/cloudflare:build: �[0m �[32m@astrojs/cloudflare:build: �[0m> @astrojs/cloudflare@6.3.0 build /home/runner/work/astro/astro/packages/integrations/cloudflare �[32m@astrojs/cloudflare:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/cloudflare:build: �[0m �[35m@astrojs/vercel:build: �[0m �[35m@astrojs/vercel:build: �[0m> @astrojs/vercel@3.4.0 build /home/runner/work/astro/astro/packages/integrations/vercel �[35m@astrojs/vercel:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/vercel:build: �[0m �[33m@astrojs/svelte:build: �[0m �[33m@astrojs/svelte:build: �[0m> @astrojs/svelte@2.2.0 build /home/runner/work/astro/astro/packages/integrations/svelte �[33m@astrojs/svelte:build: �[0m> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc �[33m@astrojs/svelte:build: �[0m �[32m@astrojs/vue:build: �[0mcache miss, executing �[2m468095e34607adf7�[0m �[33m@astrojs/node:build: �[0mcache miss, executing �[2m3c5626c6699f2f28�[0m �[34m@astrojs/mdx:build: �[0mcache miss, executing �[2m6be8fa3974e88281�[0m �[36m@astrojs/markdoc:build: �[0mcache miss, executing �[2m5b2086fabe07827d�[0m �[35m@astrojs/alpinejs:build: �[0mcache miss, executing �[2md14a6c951bdbeb75�[0m �[32m@astrojs/partytown:build: �[0mcache miss, executing �[2me116e5f9d75d3884�[0m �[33m@astrojs/node:build: �[0m �[33m@astrojs/node:build: �[0m> @astrojs/node@5.1.4 build /home/runner/work/astro/astro/packages/integrations/node �[33m@astrojs/node:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/node:build: �[0m �[32m@astrojs/vue:build: �[0m �[32m@astrojs/vue:build: �[0m> @astrojs/vue@2.2.0 build /home/runner/work/astro/astro/packages/integrations/vue �[32m@astrojs/vue:build: �[0m> astro-scripts build "src/index.ts" && astro-scripts build "src/editor.cts" --force-cjs --no-clean-dist && tsc �[32m@astrojs/vue:build: �[0m �[33m@astrojs/netlify:build: �[0mcache miss, executing �[2m17101f185e89b17e�[0m �[34m@astrojs/preact:build: �[0mcache miss, executing �[2m6404948cf792c74a�[0m �[34m@astrojs/mdx:build: �[0m �[34m@astrojs/mdx:build: �[0m> @astrojs/mdx@0.19.2 build /home/runner/work/astro/astro/packages/integrations/mdx �[34m@astrojs/mdx:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/mdx:build: �[0m �[35m@astrojs/alpinejs:build: �[0m �[35m@astrojs/alpinejs:build: �[0m> @astrojs/alpinejs@0.2.2 build /home/runner/work/astro/astro/packages/integrations/alpinejs �[35m@astrojs/alpinejs:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/alpinejs:build: �[0m �[36m@astrojs/markdoc:build: �[0m �[36m@astrojs/markdoc:build: �[0m> @astrojs/markdoc@0.2.1 build /home/runner/work/astro/astro/packages/integrations/markdoc �[36m@astrojs/markdoc:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/markdoc:build: �[0m �[32m@astrojs/partytown:build: �[0m �[32m@astrojs/partytown:build: �[0m> @astrojs/partytown@1.2.2 build /home/runner/work/astro/astro/packages/integrations/partytown �[32m@astrojs/partytown:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@astrojs/partytown:build: �[0m �[33m@astrojs/netlify:build: �[0m �[33m@astrojs/netlify:build: �[0m> @astrojs/netlify@2.2.3 build /home/runner/work/astro/astro/packages/integrations/netlify �[33m@astrojs/netlify:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/netlify:build: �[0m �[36m@astrojs/tailwind:build: �[0mcache miss, executing �[2m638f04d55d9eb19e�[0m �[34m@astrojs/preact:build: �[0m �[34m@astrojs/preact:build: �[0m> @astrojs/preact@2.2.0 build /home/runner/work/astro/astro/packages/integrations/preact �[34m@astrojs/preact:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[34m@astrojs/preact:build: �[0m �[36m@astrojs/tailwind:build: �[0m �[36m@astrojs/tailwind:build: �[0m> @astrojs/tailwind@3.1.3 build /home/runner/work/astro/astro/packages/integrations/tailwind �[36m@astrojs/tailwind:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[36m@astrojs/tailwind:build: �[0m �[35m@astrojs/prefetch:build: �[0mcache miss, executing �[2m5fa6c1c567bb45a5�[0m �[32m@benchmark/timer:build: �[0mcache miss, executing �[2m479297e72aa4af93�[0m �[35m@astrojs/prefetch:build: �[0m �[35m@astrojs/prefetch:build: �[0m> @astrojs/prefetch@0.2.3 build /home/runner/work/astro/astro/packages/integrations/prefetch �[35m@astrojs/prefetch:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[35m@astrojs/prefetch:build: �[0m �[33m@astrojs/sitemap:build: �[0mcache miss, executing �[2m241526adba55080e�[0m �[32m@benchmark/timer:build: �[0m �[32m@benchmark/timer:build: �[0m> @benchmark/timer@0.0.0 build /home/runner/work/astro/astro/benchmark/packages/timer �[32m@benchmark/timer:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[32m@benchmark/timer:build: �[0m �[33m@astrojs/sitemap:build: �[0m �[33m@astrojs/sitemap:build: �[0m> @astrojs/sitemap@1.3.1 build /home/runner/work/astro/astro/packages/integrations/sitemap �[33m@astrojs/sitemap:build: �[0m> astro-scripts build "src/**/*.ts" && tsc �[33m@astrojs/sitemap:build: �[0m Tasks: 28 successful, 28 total Cached: 5 cached, 28 total Time: 1m22.012s 🦋 �[33mwarn�[39m �[31m===============================IMPORTANT!===============================�[39m 🦋 �[33mwarn�[39m Packages will be released under the next--content-serial tag 🦋 �[33mwarn�[39m �[31m----------------------------------------------------------------------�[39m 🦋 �[36minfo�[39m npm info astro 🦋 �[36minfo�[39m npm info @astrojs/prism 🦋 �[36minfo�[39m npm info @astrojs/rss 🦋 �[36minfo�[39m npm info create-astro 🦋 �[36minfo�[39m npm info @astrojs/alpinejs 🦋 �[36minfo�[39m npm info @astrojs/cloudflare 🦋 �[36minfo�[39m npm info @astrojs/deno 🦋 �[36minfo�[39m npm info @astrojs/image 🦋 �[36minfo�[39m npm info @astrojs/lit 🦋 �[36minfo�[39m npm info @astrojs/markdoc 🦋 �[36minfo�[39m npm info @astrojs/mdx 🦋 �[36minfo�[39m npm info @astrojs/netlify 🦋 �[36minfo�[39m npm info @astrojs/node 🦋 �[36minfo�[39m npm info @astrojs/partytown 🦋 �[36minfo�[39m npm info @astrojs/preact 🦋 �[36minfo�[39m npm info @astrojs/prefetch 🦋 �[36minfo�[39m npm info @astrojs/react 🦋 �[36minfo�[39m npm info @astrojs/sitemap 🦋 �[36minfo�[39m npm info @astrojs/solid-js 🦋 �[36minfo�[39m npm info @astrojs/svelte 🦋 �[36minfo�[39m npm info @astrojs/tailwind 🦋 �[36minfo�[39m npm info @astrojs/turbolinks 🦋 �[36minfo�[39m npm info @astrojs/vercel 🦋 �[36minfo�[39m npm info @astrojs/vue 🦋 �[36minfo�[39m npm info @astrojs/markdown-component 🦋 �[36minfo�[39m npm info @astrojs/markdown-remark 🦋 �[36minfo�[39m npm info @astrojs/telemetry 🦋 �[36minfo�[39m npm info @astrojs/webapi 🦋 �[36minfo�[39m astro is being published because our local version (0.0.0-content-serial-20230522100058) has not been published on npm 🦋 �[33mwarn�[39m @astrojs/prism is not being published because version 2.1.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/rss is not being published because version 2.4.2 is already published on npm 🦋 �[33mwarn�[39m create-astro is not being published because version 3.1.5 is already published on npm 🦋 �[33mwarn�[39m @astrojs/alpinejs is not being published because version 0.2.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/cloudflare is not being published because version 6.3.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/deno is not being published because version 4.1.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/image is not being published because version 0.16.9 is already published on npm 🦋 �[33mwarn�[39m @astrojs/lit is not being published because version 2.0.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdoc is not being published because version 0.2.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/mdx is not being published because version 0.19.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/netlify is not being published because version 2.2.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/node is not being published because version 5.1.4 is already published on npm 🦋 �[33mwarn�[39m @astrojs/partytown is not being published because version 1.2.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/preact is not being published because version 2.2.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/prefetch is not being published because version 0.2.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/react is not being published because version 2.2.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/sitemap is not being published because version 1.3.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/solid-js is not being published because version 2.2.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/svelte is not being published because version 2.2.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/tailwind is not being published because version 3.1.3 is already published on npm 🦋 �[33mwarn�[39m @astrojs/turbolinks is not being published because version 0.2.2 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vercel is not being published because version 3.4.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/vue is not being published because version 2.2.0 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdown-component is not being published because version 1.0.4 is already published on npm 🦋 �[33mwarn�[39m @astrojs/markdown-remark is not being published because version 2.2.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/telemetry is not being published because version 2.1.1 is already published on npm 🦋 �[33mwarn�[39m @astrojs/webapi is not being published because version 2.1.1 is already published on npm 🦋 �[36minfo�[39m Publishing �[36m"astro"�[39m at �[32m"0.0.0-content-serial-20230522100058"�[39m 🦋 �[32msuccess�[39m packages published successfully: 🦋 astro@0.0.0-content-serial-20230522100058 🦋 Creating git tag... 🦋 New tag: astro@0.0.0-content-serial-20230522100058

@bluwy bluwy changed the title Make vite-plugin-content-virtual-mod run getEntrySlug serially Make vite-plugin-content-virtual-mod run getEntrySlug 10 at a time May 23, 2023
@ematipico
Copy link
Member

ematipico commented May 23, 2023

I wonder if the issue isn't the watcher at all... since the error says "too many open files", maybe we should use try to use fs.close() to close the file at the end of the operation.

@bluwy
Copy link
Member Author

bluwy commented May 23, 2023

I think the nodejs APIs we use to read files doesn't get the file handle, so it's automatically closed by default. But it can definitely be the watcher still causing issues. Maybe we could share the same Vite server's watcher for type generation? Could be that we have two watchers that's causing the problem 🤔

I'll go ahead and merge this first to unblock some users' setups.

@bluwy bluwy merged commit 4ce8bf7 into main May 23, 2023
14 checks passed
@bluwy bluwy deleted the get-entry-serial branch May 23, 2023 13:55
@astrobot-houston astrobot-houston mentioned this pull request May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Too many open files / UnknownContentCollectionError: site does not build
3 participants