Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update all dependencies #9138

Merged
merged 5 commits into from
Nov 21, 2023
Merged

Update all dependencies #9138

merged 5 commits into from
Nov 21, 2023

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Nov 20, 2023

Changes

This upgrades all dependencies including breaking ones, except:

  • @lit-labs/ssr-client: pinned due to 2.0 regressions before
  • @lit-labs/ssr: pinned due to 2.0 regressions before
  • lit: we don't support v3 yet
  • @types/node: keeping it as v18 for now instead of v20

Testing

Ran pnpm test at the root to run all tests (passes)

Docs

The main upgrades to document are for the remark/rehype plugins, the migration guide can touch on this a bit.

bluwy and others added 4 commits November 17, 2023 22:52
also add Chris as co-author for the first commit

Co-authored-by: delucis <delucis@users.noreply.github.com>
Copy link

changeset-bot bot commented Nov 20, 2023

🦋 Changeset detected

Latest commit: c80c408

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added feat: markdown Related to Markdown (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: example Related to an example package (scope) pkg: react Related to React (scope) pkg: preact Related to Preact (scope) pkg: solid Related to Solid (scope) pkg: lit Related to Lit (scope) pkg: integration Related to any renderer integration (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: astro Related to the core `astro` package (scope) docs pr A PR that includes documentation for review labels Nov 20, 2023
@@ -1317,7 +1317,7 @@ export interface AstroUserConfig {
* {
* markdown: {
* // Example: Translate the footnotes text to another language, here are the default English values
* remarkRehype: { footnoteLabel: "Footnotes", footnoteBackLabel: "Back to content"},
* remarkRehype: { footnoteLabel: "Footnotes", footnoteBackLabel: "Back to reference 1"},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a breaking change from syntax-tree/mdast-util-to-hast@56c88e4, but it's very unlikely to affect someone.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I understand correctly that the breaking change is the default wording is now different?

This change in default looks good to me (more accessible than many identical links), but we should maybe include a link in the changeset, just in case someone wants to update their text. (I think it's likely to affect people, but unlikely that that affect is bad/undesired.)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah it's the changed default. I can add a changeset here, maybe together with that we've upgraded the remark/rehype plugins

Copy link
Member

@delucis delucis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changeset looks good — thanks for adding that @bluwy!

@bluwy bluwy merged commit abf6012 into next Nov 21, 2023
14 checks passed
@bluwy bluwy deleted the update-all-deps branch November 21, 2023 04:09
This was referenced Nov 21, 2023
@astrobot-houston astrobot-houston mentioned this pull request Dec 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs pr A PR that includes documentation for review feat: markdown Related to Markdown (scope) pkg: astro Related to the core `astro` package (scope) pkg: create-astro Related to the `create-astro` package (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope) pkg: preact Related to Preact (scope) pkg: react Related to React (scope) pkg: solid Related to Solid (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants