Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix log message for Disable notifications #9339

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Fix log message for Disable notifications #9339

merged 2 commits into from
Dec 6, 2023
+6 −1

Conversation

morinokami
Copy link
Contributor

Changes

  • Fixed the log message to correctly display 'enabled' and 'disabled' when toggling 'Disable notifications' in the Toolbar.

Testing

  • Ran examples locally and verified that the log message has been corrected.

Docs

  • N/A

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 6, 2023

🦋 Changeset detected

Latest commit: 698c64d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Dec 6, 2023
ematipico
ematipico approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@ematipico ematipico merged commit 0bb3d53 into withastro:main Dec 6, 2023
@astrobot-houston astrobot-houston mentioned this pull request Dec 6, 2023
Merged
martrapp
martrapp approved these changes Dec 6, 2023
View reviewed changes
Copy link
Member

@martrapp martrapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

somewhat confusing due to the double negation but the fix is great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ematipico ematipico

@florian-lefebvre florian-lefebvre

@martrapp martrapp

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@morinokami @ematipico @florian-lefebvre @martrapp