Skip to content

fix: improve error message when a middleware doesn't return a Response #9434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

ematipico
Copy link
Member

Changes

The error message was old and didn't explain well the solution to solve the error.

Testing

N/A

Docs

/cc @withastro/maintainers-docs for feedback!

Copy link

changeset-bot bot commented Dec 14, 2023

🦋 Changeset detected

Latest commit: efc3d7a

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Dec 14, 2023
@ematipico ematipico requested a review from sarah11918 December 14, 2023 15:59
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would be OK with the error message as written, but, if my suggestion is technically correct, then I think it might help get the point across! Whatever you think!

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@ematipico
Copy link
Member Author

All good suggestions, thank you @sarah11918

Copy link
Member

@ElianCodes ElianCodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking all sharp!

@ematipico ematipico merged commit c01580a into main Dec 15, 2023
@ematipico ematipico deleted the fix/better-error-message branch December 15, 2023 09:22
@astrobot-houston astrobot-houston mentioned this pull request Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants