Toggle dev toolbar hitbox height when toolbar is visible #9446
+12
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 18bff8f The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
|
Thank you @alexnguyennz , could you post some screenshots of before and after the change? |
Yep sure, have updated the comment. |
bluwy
approved these changes
Dec 22, 2023
Princesseuh
reviewed
Dec 27, 2023
Princesseuh
approved these changes
Dec 28, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Sets the
dev-bar-hitbox-abovediv height to 0 when the overlay is active so it doesn't block elements in that space e.g. links from being clickable (like footer links or any links that come into that space when you're scrolling up and down).The tooltip's top value for the tooltip then includes the fixed
42pxheight of the hitbox.Before (hovering over Twitter link)
Before (hitbox)
After (hovering over Twitter link)
After (hitbox)
After (showing tooltip)
Testing
pnpm run test:match "runtime"Docs
N/A