Add fallback compile for astro script and style load #9664
Merged
+20
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 9095f71 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
matthewp
reviewed
Jan 11, 2024
| return null; | ||
| // In dev, HMR could cause this compile result to be empty, try to load it first | ||
| if (server) { | ||
| await server.transformRequest('/@fs' + filename); |
There was a problem hiding this comment.
this is inside load, this doesn't cause a loop?
There was a problem hiding this comment.
The id of this load is something like /Users/bjorn/project/src/pages/index.astro/?astro&lang.css, but the filename here would be /Users/bjorn/project/src/pages/index.astro. So it won't cause a loop and should only transform the main Astro file so we have the cache ready.
ematipico
approved these changes
Jan 12, 2024
matthewp
approved these changes
Jan 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Helps #9370 but does not fix it yet. This should reduce the occasional parsing error due to missing Astro compilation cache for its scripts and styles modules, which can often happen in HMR.
It does not fix the issue due to a Vite bug explained in #9370 (comment). I'm still trying to figure that out, but if I can't, I can probably add a workaround in a later PR too.
Testing
Tested manually with the issue's repro. I didn't add a test as the bug still exists, but it should not break other tests.
Docs
n/a. bug fix.