Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edge case that caused odd panic error #919

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Conversation

natemoo-re
Copy link
Member

Changes

  • User reported an inscrutable panic error
  • I haven't been able to reproduce the specific situation that causes the panic, but I can see where the panic is happening.
  • Doing a prerelease to confirm if this fixes the problem

Testing

I haven't figured out how to repro yet

Docs

N/A

Copy link

changeset-bot bot commented Dec 21, 2023

🦋 Changeset detected

Latest commit: 624bbe5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/compiler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@natemoo-re
Copy link
Member Author

!preview no-panic

Copy link
Contributor

 > root@0.0.0 release /home/runner/work/compiler/compiler > changeset publish "--tag" "next--no-panic" 🦋 warn ===============================IMPORTANT!=============================== 🦋 warn Packages will be released under the next--no-panic tag 🦋 warn ---------------------------------------------------------------------- 🦋 info npm info @astrojs/compiler 🦋 info @astrojs/compiler is being published because our local version (0.0.0-no-panic-20231221200720) has not been published on npm 🦋 info Publishing "@astrojs/compiler" at "0.0.0-no-panic-20231221200720" 🦋 success packages published successfully: 🦋 @astrojs/compiler@0.0.0-no-panic-20231221200720 🦋 Creating git tag... 🦋 New tag: @astrojs/compiler@0.0.0-no-panic-20231221200720

@natemoo-re
Copy link
Member Author

!preview no-panic

Copy link
Contributor

 > root@0.0.0 release /home/runner/work/compiler/compiler > changeset publish "--tag" "next--no-panic" 🦋 warn ===============================IMPORTANT!=============================== 🦋 warn Packages will be released under the next--no-panic tag 🦋 warn ---------------------------------------------------------------------- 🦋 info npm info @astrojs/compiler 🦋 info @astrojs/compiler is being published because our local version (0.0.0-no-panic-20231221204539) has not been published on npm 🦋 info Publishing "@astrojs/compiler" at "0.0.0-no-panic-20231221204539" 🦋 success packages published successfully: 🦋 @astrojs/compiler@0.0.0-no-panic-20231221204539 🦋 Creating git tag... 🦋 New tag: @astrojs/compiler@0.0.0-no-panic-20231221204539

@natemoo-re
Copy link
Member Author

!preview no-panic

Copy link
Contributor

 > root@0.0.0 release /home/runner/work/compiler/compiler > changeset publish "--tag" "next--no-panic" 🦋 warn ===============================IMPORTANT!=============================== 🦋 warn Packages will be released under the next--no-panic tag 🦋 warn ---------------------------------------------------------------------- 🦋 info npm info @astrojs/compiler 🦋 info @astrojs/compiler is being published because our local version (0.0.0-no-panic-20231221205336) has not been published on npm 🦋 info Publishing "@astrojs/compiler" at "0.0.0-no-panic-20231221205336" 🦋 success packages published successfully: 🦋 @astrojs/compiler@0.0.0-no-panic-20231221205336 🦋 Creating git tag... 🦋 New tag: @astrojs/compiler@0.0.0-no-panic-20231221205336

@natemoo-re
Copy link
Member Author

@MoustaphaDev Well part of the problem here is that I'm trying to reproduce it and I'm unable to. CI might be able to catch it, though?

@MoustaphaDev
Copy link
Member

MoustaphaDev commented Dec 21, 2023

Possibly, yes, if it's a platform specific issue

@torchsmith
Copy link

It was not working on Mac, and it was also not working on linux server.

@torchsmith
Copy link

If nate was testing on windows i wonder if it'd error out in ci or even in WSL

@natemoo-re
Copy link
Member Author

Nope, I was also trying this on macOS, but I was isolating the file to just run it through the compiler...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants