Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent <style> from getting moved in <html> #974

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Prevent <style> from getting moved in <html> #974

wants to merge 12 commits into from

Conversation

MoustaphaDev
Copy link
Member

@MoustaphaDev MoustaphaDev commented Mar 2, 2024 •
edited

Changes

Testing

Added json test to ensure a correct AST
Added tsx tests to ensure a correct result

Docs

N/A bug fix only

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2024 •
edited

⚠️ No Changeset found

Latest commit: a147f86

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

MoustaphaDev
MoustaphaDev commented Mar 2, 2024
View reviewed changes
internal/parser.go
@@ -902,8 +902,10 @@ func inHeadIM(p *parser) bool {
p.im = afterHeadIM
return true
case a.Body, a.Html, a.Br:
p.parseImpliedToken(EndTagToken, a.Head, a.Head.String())
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix was to remove this divergence from the html spec in the inHead insertion mode, see the "anything else" section to find the correct steps to be performed

natemoo-re
natemoo-re reviewed Apr 2, 2024
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this ready for review?

@MoustaphaDev
Copy link
Member Author

I wanted to get more tests to cover all issues opened about this bug, but besides that yeah. I can't work on it right now though unfortunately

@MoustaphaDev
Copy link
Member Author

I added a fair number of tests though so feel free to push it forward!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 BUG: [AST] Style tags get merged into html tag in certain situations
2 participants
@MoustaphaDev @natemoo-re