Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove middleware restriction #3319

Merged
merged 5 commits into from May 24, 2023
Merged

fix: remove middleware restriction #3319

merged 5 commits into from May 24, 2023

Conversation

ematipico
Copy link
Member

@ematipico ematipico commented May 23, 2023 •
edited

What kind of changes does this PR include?

Removes some content from the middleware section.

Description

We plan to remove the restriction around locals being serialisable.

Context: withastro/roadmap#555 (comment)

PR: withastro/astro#7174

@netlify
Copy link

netlify bot commented May 23, 2023 •
edited

✅ Deploy Preview for astro-docs-2 ready!

Name Link
🔨 Latest commit e56b68b
🔍 Latest deploy log https://app.netlify.com/sites/astro-docs-2/deploys/646e01039bcf560008345a6e
😎 Deploy Preview https://deploy-preview-3319--astro-docs-2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@ematipico ematipico force-pushed the chore/remove-middleware-restriction branch from d78be52 to 0456e38 Compare May 23, 2023 12:49
@ematipico ematipico force-pushed the chore/remove-middleware-restriction branch from 0456e38 to b53b249 Compare May 23, 2023 12:50
@ematipico ematipico requested a review from sarah11918 May 23, 2023 13:53
@ematipico @yanthomasdev
Update src/content/docs/en/guides/middleware.mdx
0b451a3 
Co-authored-by: Yan Thomas <61414485+Yan-Thomas@users.noreply.github.com>
@sarah11918 sarah11918 added the improve documentation Enhance existing documentation (e.g. add an example, improve description) label May 24, 2023
sarah11918
sarah11918 reviewed May 24, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ematipico! What do you think about something like my suggestion below? (Explained there.)?

src/content/docs/en/guides/middleware.mdx Outdated Show resolved Hide resolved
@ematipico @sarah11918
Update src/content/docs/en/guides/middleware.mdx
bf5d0fb 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
@ematipico ematipico requested a review from sarah11918 May 24, 2023 11:54
sarah11918
sarah11918 approved these changes May 24, 2023
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more change when viewing the preview of this page just for visual effect!

I checked and it looks like the change has already been released, so these docs can update immediately? If not, please add the merge-on-release label so that I DO NOT merge as soon as I update branch again and wait for the checks. :)

src/content/docs/en/guides/middleware.mdx Outdated Show resolved Hide resolved
@ematipico
Copy link
Member Author

One more change when viewing the preview of this page just for visual effect!

I checked and it looks like the change has already been released, so these docs can update immediately? If not, please add the merge-on-release label so that I DO NOT merge as soon as I update branch again and wait for the checks. :)

The change was already released, so we're good to merge this PR 😁

@sarah11918 sarah11918 merged commit 86658bc into main May 24, 2023
12 checks passed
@sarah11918 sarah11918 deleted the chore/remove-middleware-restriction branch May 24, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

@yanthomasdev yanthomasdev Awaiting requested review from yanthomasdev

Assignees
No one assigned
Labels
improve documentation Enhance existing documentation (e.g. add an example, improve description)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ematipico @sarah11918 @yanthomasdev