Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: skew protection #8188

Merged
merged 6 commits into from May 8, 2024
Merged

feat: skew protection #8188

merged 6 commits into from May 8, 2024

Conversation

ematipico
Copy link
Member

Description (required)

Adds documentation for the upcoming skew protection support for the vercel adapter.

For Astro version: 4.8.0. See astro PR #10761

@vercel Vercel
Copy link

vercel bot commented May 6, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 8, 2024 3:26pm
1 Ignored Deployment
Name Status Preview Updated (UTC)
docs-i18n ⬜️ Ignored (Inspect) May 8, 2024 3:26pm

@ematipico ematipico mentioned this pull request May 6, 2024
Merged
@astrobot-houston
Copy link
Contributor

astrobot-houston commented May 6, 2024 •
edited

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/integrations-guide/vercel.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@sarah11918 sarah11918 added this to the 4.8 milestone May 6, 2024
@sarah11918 sarah11918 added add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah! labels May 6, 2024
sarah11918
sarah11918 reviewed May 6, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @ematipico ! Just some tiny suggestions here!

src/content/docs/en/guides/integrations-guide/vercel.mdx Show resolved Hide resolved
src/content/docs/en/guides/integrations-guide/vercel.mdx Outdated Show resolved Hide resolved
@ematipico @sarah11918
Apply suggestions from code review
fa118c5 
Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
sarah11918
sarah11918 approved these changes May 7, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! This will be good to go for 4.8!

@sarah11918 sarah11918 added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label May 7, 2024
@sarah11918
Copy link
Member

Updating branch and pointing to new 4.8.0 branch

@sarah11918 sarah11918 changed the base branch from main to 4.8.0 May 7, 2024 13:10
@sarah11918 sarah11918 mentioned this pull request May 8, 2024
Merged
@sarah11918 sarah11918 merged commit 6c5b742 into 4.8.0 May 8, 2024
3 checks passed
@sarah11918 sarah11918 deleted the chore/vercel-skew-protection branch May 8, 2024 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

Assignees
No one assigned
Labels
add new content Document something that is not in docs. May require testing, confirmation, or affect other pages. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" when approved by Sarah!
Projects
None yet
Milestone
4.8
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ematipico @astrobot-houston @sarah11918