Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update some links without absolute url #8231

Merged
merged 2 commits into from May 14, 2024
Merged

Update some links without absolute url #8231

merged 2 commits into from May 14, 2024
+6 −6

Conversation

liruifengv
Copy link
Sponsor Member

Description (required)

Update some links without absolute url

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@vercel Vercel
Copy link

vercel bot commented May 9, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 14, 2024 1:38pm

@astrobot-houston
Copy link
Contributor

astrobot-houston commented May 9, 2024 •
edited

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/cms/apostrophecms.mdx Source changed, localizations will be marked as outdated.
en guides/cms/umbraco.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

sasoria
sasoria approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@sasoria sasoria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

sarah11918
sarah11918 approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I wonder how these passed our checks in the first place?? 🙌

@liruifengv
Copy link
Sponsor Member Author

liruifengv commented May 14, 2024 •
edited

Thank you! I wonder how these passed our checks in the first place?? 🙌

Maybe we need to add some checks in the link-check CI?

@liruifengv liruifengv added the Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! label May 14, 2024
@liruifengv liruifengv merged commit 72d634f into withastro:main May 14, 2024
8 checks passed
@liruifengv liruifengv deleted the fix-links branch May 14, 2024 13:39
huyikai added a commit to huyikai/astro-docs that referenced this pull request May 15, 2024
@huyikai
i18n(zh-cn): Update content about upstream withastro#8231
394c397
@huyikai huyikai mentioned this pull request May 15, 2024
Merged
liruifengv added a commit to huyikai/astro-docs that referenced this pull request May 15, 2024
@liruifengv
Merge branch 'main' into 20240515-withastro#8231
882b98f
liruifengv added a commit that referenced this pull request May 15, 2024
@huyikai @liruifengv
i18n(zh-cn): Update content about upstream #8231 (#8275)
fff46b5 
Co-authored-by: liruifengv <liruifeng1024@gmail.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@liruifengv @wpplumber
Update some links without absolute url (withastro#8231)
8ecaadf
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@huyikai @liruifengv @wpplumber
i18n(zh-cn): Update content about upstream withastro#8231 (withastro#…
d95cce8 
…8275)

Co-authored-by: liruifengv <liruifeng1024@gmail.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@liruifengv @wpplumber
Update some links without absolute url (withastro#8231)
c4f901e
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@huyikai @liruifengv @wpplumber
i18n(zh-cn): Update content about upstream withastro#8231 (withastro#…
ba78cf1 
…8275)

Co-authored-by: liruifengv <liruifeng1024@gmail.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@liruifengv @wpplumber
Update some links without absolute url (withastro#8231)
607de68
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@huyikai @liruifengv @wpplumber
i18n(zh-cn): Update content about upstream withastro#8231 (withastro#…
b940043 
…8275)

Co-authored-by: liruifengv <liruifeng1024@gmail.com>
@jsparkdev jsparkdev mentioned this pull request May 17, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarah11918 sarah11918 sarah11918 approved these changes

@sasoria sasoria sasoria approved these changes

Assignees
No one assigned
Labels
Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@liruifengv @astrobot-houston @sarah11918 @sasoria