Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n(pl): update nav.ts #8240

Merged
merged 4 commits into from May 14, 2024
Merged

i18n(pl): update nav.ts #8240

merged 4 commits into from May 14, 2024

Conversation

V3RON
Copy link
Contributor

@V3RON V3RON commented May 9, 2024

Description

This pull request makes the following changes:

  • adds missing translation keys
  • reformats to follow the structure of the original one
  • provides updated translations to all keys

Related issues & labels

  • Suggested label: i18n

Copy link

vercel bot commented May 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 14, 2024 9:29pm

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label May 9, 2024
@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented May 9, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
pl nav.ts Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@gacek1123
Copy link
Contributor

I have a general question. How do we want to go about translating the word "tutorial"? "Kurs" or "samouczek"?

@V3RON
Copy link
Contributor Author

V3RON commented May 10, 2024

I have a general question. How do we want to go about translating the word "tutorial"? "Kurs" or "samouczek"?

I don't have strong opinion on that. I suggest staying with 'samouczek' for now and discuss it later on Discord. There are more words like that with multiple translations available and we all should agree to use certain options only.

src/i18n/pl/nav.ts Outdated Show resolved Hide resolved
src/i18n/pl/nav.ts Outdated Show resolved Hide resolved
src/i18n/pl/nav.ts Outdated Show resolved Hide resolved
src/i18n/pl/nav.ts Show resolved Hide resolved
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work peeps 🙌

@yanthomasdev yanthomasdev merged commit d1ef8d2 into withastro:main May 14, 2024
8 checks passed
@V3RON V3RON deleted the patch-1 branch May 15, 2024 06:27
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
* i18n(pl): update nav.ts

* fix: add missing commas

* fix: make changes requested by reviewer

---------

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
* i18n(pl): update nav.ts

* fix: add missing commas

* fix: make changes requested by reviewer

---------

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
* i18n(pl): update nav.ts

* fix: add missing commas

* fix: make changes requested by reviewer

---------

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants