Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shikiConfig.experimentalThemes -> shikiConfig.themes #8243

Merged
merged 2 commits into from May 14, 2024

Conversation

austincrim
Copy link
Contributor

Description (required)

It appears that Astro 4.5 stabilized dual theme support for Shiki and updated this property name. experimentalThemes did not work for me with astro@4.8.0.

Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 14, 2024 0:37am

@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented May 10, 2024

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

Locale File Note
en guides/markdown-content.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @austincrim ! I have to admit, I'm super confused because we did in fact have a corresponding docs PR to accompany 4.5:

image

Somehow, the old wording must have been reintroduced in a later PR. But we appreciate you taking the time to fix this, and are happy to welcome you to Team Docs! 🥳

@sarah11918 sarah11918 added code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)! labels May 14, 2024
@sarah11918 sarah11918 merged commit a850195 into withastro:main May 14, 2024
7 of 8 checks passed
@austincrim austincrim deleted the patch-1 branch May 15, 2024 02:14
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
…astro#8243)

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
…astro#8243)

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
…astro#8243)

Co-authored-by: Sarah Rainsberger <sarah@rainsberger.ca>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code snippet update Updates a code sample: typo, outdated code etc. Merge Queue Approved and ready to be merged (wait for feature release if also labelled M-O-R)!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants