Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A typo in the code sample 4.mdx #8255

Merged
merged 2 commits into from May 14, 2024
Merged

A typo in the code sample 4.mdx #8255

merged 2 commits into from May 14, 2024

Conversation

stixijin
Copy link
Contributor

A typo in the get code example - because of this I get the error "No API Route handler exists for the method "GET" for the route "/rss.xml". Found handlers: "Get" When building xml is not created. When editing from get to GET everything works.

Description (required)

Related issues & labels (optional)

  • Closes #
  • Suggested label:

@stixijin
A typo in the code sample 4.mdx
7e77ac5 
A typo in the get code example - because of this I get the error "No API Route handler exists for the method "GET" for the route "/rss.xml". Found handlers: "Get" When building xml is not created. When editing from get to GET everything works.
@vercel Vercel
Copy link

vercel bot commented May 11, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview May 14, 2024 9:14pm

@github-actions github-actions bot added the i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help! label May 11, 2024
@astrobot-houston
Copy link
Contributor

Hello! Thank you for opening your first PR to Astro’s Docs! 🎉

Here’s what will happen next:

  1. Our GitHub bots will run to check your changes.
    If they spot any broken links you will see some error messages on this PR.
    Don’t hesitate to ask any questions if you’re not sure what these mean!

  2. In a few minutes, you’ll be able to see a preview of your changes on Vercel 🥳

  3. One or more of our maintainers will take a look and may ask you to make changes.
    We try to be responsive, but don’t worry if this takes a few days.

@astrobot-houston
Copy link
Contributor

astrobot-houston commented May 11, 2024 •
edited

Lunaria Status Overview

🌑 This pull request will not trigger status changes.

Learn more

Lunaria automatically ignores changes on specific PRs by adding a ignored keyword in its title. Found: typo.

You can change this by either removing the keyword above from the PR's title, or modifying the ignoreKeywords property in your Lunaria configuration file.

Tracked Files

Locale File Note
ru tutorial/5-astro-api/4.mdx Localization changed, will be marked as complete.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

at-the-vr
at-the-vr reviewed May 12, 2024
View reviewed changes
Copy link
Contributor

@at-the-vr at-the-vr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can confirm this is correct after checking en/tutorial/5-astro-api/4 LGTM 👍

yanthomasdev
yanthomasdev approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@yanthomasdev yanthomasdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks

@yanthomasdev yanthomasdev merged commit a9af083 into withastro:main May 14, 2024
8 checks passed
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@stixijin @yanthomasdev @wpplumber
i18n(ru): fix typo in the code sample 4.mdx (withastro#8255)
c997d97 
A typo in the get code example - because of this I get the error "No API Route handler exists for the method "GET" for the route "/rss.xml". Found handlers: "Get" When building xml is not created. When editing from get to GET everything works.

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@stixijin @yanthomasdev @wpplumber
i18n(ru): fix typo in the code sample 4.mdx (withastro#8255)
2e047e8 
A typo in the get code example - because of this I get the error "No API Route handler exists for the method "GET" for the route "/rss.xml". Found handlers: "Get" When building xml is not created. When editing from get to GET everything works.

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
wpplumber pushed a commit to wpplumber/astro-docs that referenced this pull request May 15, 2024
@stixijin @yanthomasdev @wpplumber
i18n(ru): fix typo in the code sample 4.mdx (withastro#8255)
1a170c1 
A typo in the get code example - because of this I get the error "No API Route handler exists for the method "GET" for the route "/rss.xml". Found handlers: "Get" When building xml is not created. When editing from get to GET everything works.

Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@at-the-vr at-the-vr at-the-vr left review comments

@yanthomasdev yanthomasdev yanthomasdev approved these changes

Assignees
No one assigned
Labels
i18n Anything to do with internationalization & translation efforts - ask @YanThomas for help!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@stixijin @astrobot-houston @yanthomasdev @at-the-vr