Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hybrid rendering stage 3 proposal #565

Merged
merged 7 commits into from Jun 5, 2023
Merged

Hybrid rendering stage 3 proposal #565

merged 7 commits into from Jun 5, 2023

Conversation

matthewp
Copy link
Contributor

Summary

Provide a output: 'hybrid' mode to allow static sites to opt-in certain pages to be dynamic (not prerendered).

Links

proposals/hybrid-rendering.md Outdated Show resolved Hide resolved
proposals/hybrid-rendering.md Outdated Show resolved Hide resolved
proposals/hybrid-rendering.md Show resolved Hide resolved
proposals/hybrid-rendering.md Outdated Show resolved Hide resolved
proposals/hybrid-rendering.md Outdated Show resolved Hide resolved
matthewp and others added 3 commits April 28, 2023 08:37
Co-authored-by: Happydev <81974850+MoustaphaDev@users.noreply.github.com>
Co-authored-by: Happydev <81974850+MoustaphaDev@users.noreply.github.com>
Co-authored-by: Happydev <81974850+MoustaphaDev@users.noreply.github.com>
@jamesli2021
Copy link

jamesli2021 commented Apr 29, 2023

As opposite to 'server', using 'hybrid' is confusing, I prefer 'defaultstatic' or 'defaultprerender' as it's more meaningful in the docs.

matthewp and others added 2 commits May 15, 2023 08:52
Co-authored-by: Happydev <81974850+MoustaphaDev@users.noreply.github.com>
Co-authored-by: Happydev <81974850+MoustaphaDev@users.noreply.github.com>
Co-authored-by: Happydev <81974850+MoustaphaDev@users.noreply.github.com>
@matthewp
Copy link
Contributor Author

This has been out as experimental since 2.5. I'm moving to have this RFC merged in and experimental label removed. We'll now enter the final comment period. If anyone has issue with this RFC being merged please voice now, thanks!

@zadeviggers
Copy link

Again, I'm still mainly in favor of not introducing a "hybrid" option, and instead going for an object configuration. But I can see how this way is simpler for the user, if less future-proof and more confusing, so I don't feel too strongly either way.

@matthewp
Copy link
Contributor Author

matthewp commented Jun 1, 2023

@zadeviggers Did I miss this idea? Could you link to it? The object configuration I mean.

@zadeviggers
Copy link

@matthewp here are the relevant comments:
#539 (comment)
#539 (comment)

@matthewp
Copy link
Contributor Author

matthewp commented Jun 2, 2023

Ah yeah. I see what you mean. Personally I would keep output as a string and then have a separate option for the default:

output: 'server',
build: {
  prerenderDefault: false
}

I think there's still some perception problem with this approach where people see the default being false as being the wrong choice.

I think we should proceed with the current 'hybrid' option for now. 3.0 is coming up so we can still make this better in the future. Since this is mostly about bikeshedding the config name and not how exactly it works. Sound fair?

@matthewp
Copy link
Contributor Author

matthewp commented Jun 5, 2023

We're going to go with this approach for now. Happy to continue refining it as we approach 3.0.

@matthewp matthewp merged commit 2cede26 into main Jun 5, 2023
@matthewp matthewp deleted the hybrid-rendering branch June 5, 2023 13:34
@zadeviggers
Copy link

Awesome, that sounds good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants