Rewriting

[ematipico]

Summary

Links

• Rendered RFC
• Stage 2 Proposal
• Stage 1 Proposal

[matthewp]

Doesn't it call matchRoute internally? I'm pretty sure that code does check trailing slash rules.

[ematipico]

Internally, we use route.pattern.test. pattern is the path-to-regex. Does this regex check for trailing slashes? If so I can omit the paragraph

[matthewp]

We should figure out what happens if there are cycles; for example if /foo reroutes to /bar which reroutes back to /foo on an endless loop. Should we do anything to try and prevent that?

[ematipico]

We should figure out what happens if there are cycles; for example if /foo reroutes to /bar which reroutes back to /foo on an endless loop. Should we do anything to try and prevent that?

In my early prototype, I was able to detect loops. I added a paragraph for that here c8f69ac (#901)

[matthewp]

Let's say you had a middleware stack like this:

i18n -> custom -> auth -> page

Given that reroute() returns a response, I think this means that if you call reroute in the custom middleware function, then auth will not be called. Is that right? Or it the function aware of where the current point is in the middleware chain and continues to call the proceeding middleware functions?

[ematipico]

Let's say you had a middleware stack like this:

i18n -> custom -> auth -> page

Given that reroute() returns a response, I think this means that if you call reroute in the custom middleware function, then auth will not be called. Is that right? Or it the function aware of where the current point is in the middleware chain and continues to call the proceeding middleware functions?

That's right, I updated the proposal to better explain the API and how next("/new") vs ctx.reroute("/new") differ

[ematipico]

The commit f9ec599 (#901) changes "reroute" to "rewrite". We assessed that the majority of frameworks and services out there use the term "rewrite".