Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment and heart icons #1837

Merged
merged 2 commits into from May 14, 2024
Merged

Add comment and heart icons #1837

merged 2 commits into from May 14, 2024

Conversation

delucis
Copy link
Member

@delucis delucis commented May 7, 2024

Description

  • Follow up to Sidebar Reorganization Implementation docs#8197

  • Adds three new icons: comment, comment-alt and heart:
    The three new icons. The comment icons are variations on speech bubbles, one round the other square. The heart icon is an outlined stylized heart shape.

  • We’re using Unicons’ comment-alt in docs currently, but it felt weird to add that without also adding the non-alt version, so I’ve added both.

Copy link

changeset-bot bot commented May 7, 2024

🦋 Changeset detected

Latest commit: 91e54bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@astrojs/starlight Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented May 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
starlight ✅ Ready (Inspect) Visit Preview May 7, 2024 9:44am
1 Ignored Deployment
Name Status Preview Updated (UTC)
starlight-i18n ⬜️ Ignored (Inspect) May 7, 2024 9:44am

@github-actions github-actions bot added the 🌟 core Changes to Starlight’s main package label May 7, 2024
@astrobot-houston
Copy link
Collaborator

size-limit report 📦

Path Size
/index.html 6.1 KB (0%)
/_astro/*.js 22.02 KB (0%)
/_astro/*.css 13.45 KB (0%)

@delucis delucis changed the title Adds comment icons Add comment and heart icons May 7, 2024
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're looking good to me in the Icon list in Starlight docs!

image

Copy link
Member

@dreyfus92 dreyfus92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, we're extending the icon library of Starlight! LGTM ✅

@SatanshuMishra
Copy link

This looks great! Thank you @delucis!

@delucis delucis merged commit a33a122 into main May 14, 2024
12 checks passed
@delucis delucis deleted the chris/comment-icons branch May 14, 2024 22:37
@astrobot-houston astrobot-houston mentioned this pull request May 14, 2024
HiDeoo added a commit to HiDeoo/starlight that referenced this pull request May 15, 2024
* main:
  i18n(zh-cn): Update `overrides.md` (withastro#1864)
  [ci] format
  [ci] release (withastro#1839)
  Add comment and heart icons (withastro#1837)
  [ci] format
  Add HackerOne Icon (withastro#1840)
  Update Vietnamese translation (withastro#1863)
  Move site title `href` to route data for easier overrides (withastro#1842)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌟 core Changes to Starlight’s main package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants