Add HackerOne Icon #1840
Merged
Add HackerOne Icon #1840
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miaha Cybersec <miahacybersec@gmail.com>
Signed-off-by: Miaha Cybersec <miahacybersec@gmail.com>
🦋 Changeset detectedLatest commit: 12e5429 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Miaha Cybersec <miahacybersec@gmail.com>
delucis
reviewed
May 8, 2024
There was a problem hiding this comment.
Thanks for the contribution @MiahaCybersec — looks good, I think.
One detail: what do you think of using hackerOne as the icon/config key instead of the all lowercase hackerone? In general we do that for icons that are technically two words (e.g. openCollective.
Co-authored-by: Chris Swithinbank <swithinbank@gmail.com>
Signed-off-by: Miaha Cybersec <miahacybersec@gmail.com>
delucis
approved these changes
May 8, 2024
There was a problem hiding this comment.
Thanks for making those updates @MiahaCybersec! Looks ready to go out with our next release 🚀
Merged
HiDeoo
added a commit
to HiDeoo/starlight
that referenced
this pull request
May 15, 2024
* main: i18n(zh-cn): Update `overrides.md` (withastro#1864) [ci] format [ci] release (withastro#1839) Add comment and heart icons (withastro#1837) [ci] format Add HackerOne Icon (withastro#1840) Update Vietnamese translation (withastro#1863) Move site title `href` to route data for easier overrides (withastro#1842)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds 1 new icon:
HackerOneIn the event that a security researcher uses Starlight for their personal blog or website, it might be nice for them to be able to link their HackerOne profile at the top of their website.