chore: upgrade internally to jest@28 #3395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noomorph
force-pushed
the
chore/jest-28-upgrade-internally
branch
from
c59df11
to
f8baf48
Compare
noomorph
force-pushed
the
chore/jest-28-upgrade-internally
branch
from
f8baf48
to
c22795a
Compare
d4vidi
reviewed
May 24, 2022
| @@ -1,6 +1,6 @@ | |||
| // @ts-nocheck | |||
| const _ = require('lodash'); | |||
| const parse = require('yargs/yargs').Parser; | |||
| const parse = require('yargs-parser'); | |||
There was a problem hiding this comment.
@noomorph so in fact, this should unbind us from the known Jest hacks related to yargs? Does this work with jest 27 ( - I think is the most important question here)?
There was a problem hiding this comment.
Yes, it works "gam ve gam".
P. S. I'll reiterate: Jest has no hacks for yargs. I just see that Jest fails on a specific re-export, that's why here I'm using a direct reference and omitting that glitchy re-export.
There was a problem hiding this comment.
Lol, nice. Except for maybe the usual effect adding a dependency might have, I see no reason to approve this, then. LMK when it's out of draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Maintenance PR.
Upgrades all the sub-projects internally to Jest 28 (fixes #3396)
It has a couple of issues, though:
@types/jestdevDependencies at the moment. Trying to solve it here: chore: drop old @types/jest^27 kulshekhar/ts-jest#3513require("yargs/yargs").Parser– created a bug report to Jest: [Bug]: import behavior has been broken for certain cases jestjs/jest#12843All the issues have been resolved via various workarounds, but this makes me wary about merging this PR soon. I'd wait for some official responses above.