Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: playlist #3

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

feat: playlist #3

wants to merge 7 commits into from

Conversation

daomry
Copy link

@daomry daomry commented May 10, 2024

added a playlist component

todo: extenelize state

Copy link
Collaborator

@PeterShershov PeterShershov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These comments are for Codux issues and suggestios so mo need to fix anything just address the svgr one.

@@ -32,5 +32,5 @@
"@styles/*": "./src/styles/*"
}
},
"svgLoader": "svgr"
"svgLoader": "asset"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure? @anatfenn and @ItayWix are importing SVGs with SVGR in their components.

Comment on lines +11 to +14
/**
* This component was created using Codux's Default new component template.
* To create custom component templates, see https://help.codux.com/kb/en/article/kb16522
*/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

className?: string;
}

/**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

playing: Song;
}

/**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

defaultChecked?: boolean;
}

/**
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

export default createBoard({
name: 'PlayListItem',
Board: () => (
<div>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this div needed?

import { createBoard } from '@wixc3/react-board';
import { PlayList } from '../../../components/play-list/play-list';

const songs = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's put it in a constants file so we can reuse it in other boards

@@ -0,0 +1,5 @@
.root {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants