-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: playlist #3
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These comments are for Codux issues and suggestios so mo need to fix anything just address the svgr one.
@@ -32,5 +32,5 @@ | |||
"@styles/*": "./src/styles/*" | |||
} | |||
}, | |||
"svgLoader": "svgr" | |||
"svgLoader": "asset" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/** | ||
* This component was created using Codux's Default new component template. | ||
* To create custom component templates, see https://help.codux.com/kb/en/article/kb16522 | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
className?: string; | ||
} | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
playing: Song; | ||
} | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
defaultChecked?: boolean; | ||
} | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove
export default createBoard({ | ||
name: 'PlayListItem', | ||
Board: () => ( | ||
<div> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this div needed?
import { createBoard } from '@wixc3/react-board'; | ||
import { PlayList } from '../../../components/play-list/play-list'; | ||
|
||
const songs = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's put it in a constants file so we can reuse it in other boards
@@ -0,0 +1,5 @@ | |||
.root { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why?
added a playlist component
todo: extenelize state