Stop labels being read out multiple times #377
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gbirke
requested changes
May 7, 2024
There are 3 forms on the donation page that had duplicated fields causing the screen reader to read all of them. - Adds namespacing for the forms so each field has a unique id and label attached - Adds parameters for explicitly setting ids to form fields - Fix tests and hookups Ticket: https://phabricator.wikimedia.org/T362951
gbirke
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are 3 forms on the donation page that had duplicated fields causing the screen reader to read all of them.
Ticket: https://phabricator.wikimedia.org/T362951