Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve labels on membership payment fields #391

Merged
merged 1 commit into from
May 23, 2024
Merged

Conversation

Abban
Copy link
Member

@Abban Abban commented May 15, 2024

This replaces headings on the payment page with legends
making the form a little more compatible with screen
readers.

Ticket: https://phabricator.wikimedia.org/T364950

@Abban Abban added the 🦮 accessibility code that improves accessibility label May 15, 2024
@moiikana
Copy link
Contributor

the question for the banking information still seems to be in an old format / not adapted:
Bildschirmfoto vom 2024-05-21 17-27-18

@Abban
Copy link
Member Author

Abban commented May 22, 2024

The Bank Data field still isn't converted to a new field, and making those improvements will have to go through the PM. I added a ticket for it last week, which I just added a point to look at the labels to https://phabricator.wikimedia.org/T364953

@Abban Abban changed the title Improve labels on membership payment fields [DNM] Improve labels on membership payment fields May 22, 2024
@Abban Abban changed the title [DNM] Improve labels on membership payment fields Improve labels on membership payment fields May 22, 2024
This replaces headings on the payment page with legends
making the form a little more compatible with screen
readers.

Ticket: https://phabricator.wikimedia.org/T364950
Base automatically changed from label-namespaces to main May 23, 2024 08:04
@Abban Abban merged commit 930b9e0 into main May 23, 2024
1 check passed
@Abban Abban deleted the membership-labels branch May 23, 2024 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🦮 accessibility code that improves accessibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants