Convert locale selector to form #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Abban
force-pushed
the
alternate-locale-selector
branch
from
3fab50f
to
536450d
Compare
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Abban
force-pushed
the
alternate-locale-selector
branch
from
536450d
to
a231785
Compare
This gives us free native keyboard navigation and simplifies the process of selecting a language. Ticket: https://phabricator.wikimedia.org/T361781
Abban
force-pushed
the
alternate-locale-selector
branch
from
a231785
to
b2434cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives us free native keyboard navigation and simplifies
the process of selecting a language.
Ticket: https://phabricator.wikimedia.org/T361781