Make Modal Accessible #394
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Abban
commented
May 17, 2024
Abban
commented
- Moved it into a Teleport, so it can load outside the application
- Added a shared modal state composable
- App now goes inert and stops scrolling when a modal is open
- Moved it into a Teleport, so it can load outside the application - Added a shared modal state composable - App now goes inert and stops scrolling when a modal is open Ticket: https://phabricator.wikimedia.org/T361818
Abban
force-pushed
the
modal-accessibility
branch
from
eae0010
to
838b9ef
Compare
|
Closing in favour of using a native HTML modal #400 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.