tooling + actions pr #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeeshanlakhani
force-pushed
the
zl/tooling
branch
4 times, most recently
from
33ea017
to
4944d28
Compare
|
Awesome @zeeshanlakhani! It is great to see the security CI checks. 🎉 |
appcypher
reviewed
Oct 13, 2022
| console_error_panic_hook = { version = "0.1", optional = true } | ||
| wee_alloc = { version = "0.4", optional = true } |
There was a problem hiding this comment.
Turns out wee-alloc hasn't brought much improvement to our wasm size or we've been using it wrong.
There was a problem hiding this comment.
It's essentially dead anyway. rustwasm/wee_alloc#85 + rustsec/advisory-db#1394. We can look at other allocators tho, of interest.
appcypher
reviewed
Oct 13, 2022
zeeshanlakhani
force-pushed
the
zl/tooling
branch
from
a3073b5
to
8a925a1
Compare
zeeshanlakhani
force-pushed
the
zl/tooling
branch
from
8a925a1
to
b10aed9
Compare
|
ok, coverage updated minus some codecov UI weirdness. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Tooling PR, including: