Remove MANIFEST.in in favour of setup.cfg package data

[FollowTheProcess]

This PR removes MANIFEST.in in favour of specifying required package data in setup.cfg

I've validated that the produced tarballs are equivalent by running pyproject-build then extracting the resulting tarball to verify it's contents:

Before (with MANIFEST.in)

After (with setup.cfg package_data)

The only entries in MANIFEST.in were py.typed and anything with a .jinja2 extension which you can see in the images are still present 🙂

[DiddiLeija]

Sounds fine to me!

[henryiii]

Keep in mind, this will make the .jinga2's available in the wheel, while before it was only in the SDist. Not saying that's wrong or right, that's just a change. (py.typed obviously should be in the wheels)

[FollowTheProcess]

Keep in mind, this will make the .jinga2's available in the wheel, while before it was only in the SDist. Not saying that's wrong or right, that's just a change. (py.typed obviously should be in the wheels)

Ahh okay, didn't know that! Are there any unwanted consequences of this that you know of?

[henryiii]

Looking at it, it seems like it needs to be there to work - hmm, include_package_data is True, so this might have already been there. If that's the case, there's certainly no harm. It might be a good idea to add a check-manifest check? Unless you plan to move to Flit or something soon.

[henryiii]

It's usually a nice idea to include the tests folder in the SDist, but not the wheel. Currently it's not in the SDist.

[FollowTheProcess]

It's usually a nice idea to include the tests folder in the SDist, but not the wheel. Currently it's not in the SDist.

I personally see no real problem in including the tests in the SDist 👍🏻 would this require the MANIFEST.in?

[henryiii]

Yes, it would (otherwise you'd end up adding it to the wheel, at least any way I can think of).

[FollowTheProcess]

Okay cool, it would be good to get some more input on including tests in the SDist and if we go that way I'll close this off and we can do that instead 👍🏻

[FollowTheProcess]

Closing in favour of #552 and adding tests to the SDist (which requires MANIFEST.in)