Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: more option argument completions #707

Merged
merged 10 commits into from Feb 20, 2024
Merged

feat: more option argument completions #707

merged 10 commits into from Feb 20, 2024

Conversation

scop
Copy link
Contributor

@scop scop commented Apr 23, 2023

See individual commits for details.

@scop
feat: add envdir and report completions
e049728
@scop
feat: add python completions
da512cd
@scop
feat: add tag completion
86b6c92
@scop
feat: add keywords non-completion
89fa669 
This will actually only prevent completions with bash if the completion
was registered using
`register-python-argcomplete --complete-arguments -- nox` (i.e. with
_all_ fallback completions disabled, not just the readline ones). But it
does not hurt if registered without doing so.
stasfilin
stasfilin suggested changes Jul 13, 2023
View reviewed changes
Copy link
Contributor

@stasfilin stasfilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good morning,

I have a few suggestions to share

nox/_options.py Outdated Show resolved Hide resolved
nox/_options.py Outdated Show resolved Hide resolved
nox/_options.py Outdated Show resolved Hide resolved
nox/_options.py Show resolved Hide resolved
nox/_options.py Outdated Show resolved Hide resolved
nox/_options.py Outdated Show resolved Hide resolved
nox/_options.py Outdated Show resolved Hide resolved
nox/_options.py Outdated Show resolved Hide resolved
nox/_options.py Outdated Show resolved Hide resolved
nox/_options.py Outdated Show resolved Hide resolved
@scop
Copy link
Contributor Author

scop commented Jul 16, 2023

Thanks for the review, @stasfilin, comments addressed. A few mypy issues remain, will need to look into them:

nox/_options.py:25: error: Cannot find implementation or library stub for module named "argcomplete.completers"  [import]
nox/_options.py:25: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
nox/_options.py:246: error: Generator has incompatible item type "Union[str, Sequence[str], bool, None]"; expected "Optional[str]"  [misc]

@stasfilin
Copy link
Contributor

@scop Hi
Do you need help with these errors?

@scop
Copy link
Contributor Author

scop commented Jul 17, 2023

Thanks for the offer, however I had already worked on them, 0cb4762 has workarounds.

stasfilin
stasfilin approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@stasfilin stasfilin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
@theacodes Can you also please check? Thank you.

@henryiii henryiii mentioned this pull request Feb 19, 2024
Closed
@theacodes theacodes merged commit ea9ea27 into wntrblm:main Feb 20, 2024
18 checks passed
@scop scop deleted the feat/arg-completions branch February 23, 2024 21:04
github-actions bot pushed a commit to msclock/sphinx-deployment that referenced this pull request Mar 4, 2024
@semantic-release-bot
chore(release): 0.0.20 [skip ci]
709fba1 
## [0.0.20](v0.0.19...v0.0.20) (2024-03-04)

### Chores

* **deps:** bump wntrblm/nox from 2023.04.22 to 2024.03.02 ([#57](#57)) ([d177375](d177375)), closes [wntrblm/nox#762](wntrblm/nox#762) [wntrblm/nox#787](wntrblm/nox#787) [wntrblm/nox#730](wntrblm/nox#730) [wntrblm/nox#780](wntrblm/nox#780) [wntrblm/nox#770](wntrblm/nox#770) [wntrblm/nox#707](wntrblm/nox#707) [wntrblm/nox#687](wntrblm/nox#687) [wntrblm/nox#756](wntrblm/nox#756) [wntrblm/nox#652](wntrblm/nox#652) [wntrblm/nox#712](wntrblm/nox#712) [wntrblm/nox#781](wntrblm/nox#781) [wntrblm/nox#786](wntrblm/nox#786) [wntrblm/nox#684](wntrblm/nox#684) [wntrblm/nox#723](wntrblm/nox#723) [wntrblm/nox#725](wntrblm/nox#725) [wntrblm/nox#714](wntrblm/nox#714) [wntrblm/nox#715](wntrblm/nox#715) [wntrblm/nox#696](wntrblm/nox#696) [wntrblm/nox#774](wntrblm/nox#774) [wntrblm/nox#782](wntrblm/nox#782) [wntrblm/nox#722](wntrblm/nox#722) [wntrblm/nox#724](wntrblm/nox#724) [wntrblm/nox#721](wntrblm/nox#721) [wntrblm/nox#744](wntrblm/nox#744) [wntrblm/nox#738](wntrblm/nox#738) [wntrblm/nox#762](wntrblm/nox#762) [wntrblm/nox#787](wntrblm/nox#787) [wntrblm/nox#730](wntrblm/nox#730) [wntrblm/nox#780](wntrblm/nox#780) [wntrblm/nox#770](wntrblm/nox#770) [wntrblm/nox#707](wntrblm/nox#707) [wntrblm/nox#687](wntrblm/nox#687) [wntrblm/nox#756](wntrblm/nox#756) [wntrblm/nox#652](wntrblm/nox#652) [wntrblm/nox#712](wntrblm/nox#712) [wntrblm/nox#781](wntrblm/nox#781) [wntrblm/nox#786](wntrblm/nox#786) [wntrblm/nox#684](wntrblm/nox#684) [wntrblm/nox#723](wntrblm/nox#723) [wntrblm/nox#725](wntrblm/nox#725) [wntrblm/nox#714](wntrblm/nox#714) [wntrblm/nox#715](wntrblm/nox#715) [wntrblm/nox#696](wntrblm/nox#696) [wntrblm/nox#774](wntrblm/nox#774) [wntrblm/nox#782](wntrblm/nox#782) [wntrblm/nox#722](wntrblm/nox#722) [wntrblm/nox#724](wntrblm/nox#724) [wntrblm/nox#721](wntrblm/nox#721) [wntrblm/nox#744](wntrblm/nox#744) [#789](https://github.com/msclock/sphinx-deployment/issues/789) [#787](https://github.com/msclock/sphinx-deployment/issues/787) [#786](https://github.com/msclock/sphinx-deployment/issues/786) [#781](https://github.com/msclock/sphinx-deployment/issues/781) [#784](https://github.com/msclock/sphinx-deployment/issues/784) [#780](https://github.com/msclock/sphinx-deployment/issues/780) [#730](https://github.com/msclock/sphinx-deployment/issues/730) [#782](https://github.com/msclock/sphinx-deployment/issues/782) [#783](https://github.com/msclock/sphinx-deployment/issues/783) [#762](https://github.com/msclock/sphinx-deployment/issues/762)

### CI

* set proper permission for preview job ([#56](#56)) ([d65e8a1](d65e8a1))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theacodes theacodes theacodes approved these changes

@stasfilin stasfilin stasfilin approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@scop @stasfilin @theacodes