Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added venv_location option to specify virtualenv location #785

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Commits on Feb 27, 2024

  1. Configuration menu
    Copy the full SHA
    8636ce3 View commit details
    Browse the repository at this point in the history
  2. 'chore: wrap venv_location with os.path.expanuser

    There was an edge case where the user could pass something like
    `venv_locaiton="~/tmp/venv"`, but this would be place in a directory
    `$PWD/~/tmp/venv`.  So now use `os.path.expanduser(venv_location)` to
    fix this.
    wpk committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    ea8e444 View commit details
    Browse the repository at this point in the history
  3. chore: fix issue with tests

    Got rid of venv_location tests that created folder in home directory
    wpk committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    3c8949e View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. chore: venv_location no accepts str | os.PathLike[str]

    The user can pass a string or Path object to set venv_location. Note
    that for now, I left in `os.path.expanduser`. This coverts things like
    `venv_location="~/path/to/dir"` to `$HOME/path/to/dir` instead of
    `$PWD/~/path/to/dir`. If you really want the latter behavior, you can
    pass in `Path.cwd().joinpath("~", "path", "to", "dir")`
    wpk committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    0516317 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    754cecb View commit details
    Browse the repository at this point in the history
  3. chore: Safety check venv_location for multiple python or parametrize

    * Now raises error if passing directly multiple pythons or parametrize
    for session with `venv_location`
    * With `venv_location` set, ignore (and warn) `--extra-python`
    * Warn that session sets `venv_location`
    wpk committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    ff03ae4 View commit details
    Browse the repository at this point in the history