Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements #258

Closed
wants to merge 6 commits into from
Closed

Small improvements #258

wants to merge 6 commits into from

Conversation

darqs
Copy link
Collaborator

@darqs darqs commented Jan 11, 2020

Improvements:

@darqs darqs requested a review from wojtkowiak January 11, 2020 17:49
@codecov-io
Copy link

codecov-io commented Jan 11, 2020

Codecov Report

Merging #258 into master will increase coverage by 0.53%.
The diff coverage is 27.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #258      +/-   ##
==========================================
+ Coverage   59.41%   59.94%   +0.53%     
==========================================
  Files          20       17       -3     
  Lines        1498     1493       -5     
==========================================
+ Hits          890      895       +5     
+ Misses        608      598      -10
Impacted Files Coverage Δ
skeleton/app.js 5.09% <0%> (-0.24%) ⬇️
skeleton/modules/localServer.js 90.09% <100%> (+0.25%) ⬆️
skeleton/modules/dummy.js
skeleton/cordova.js
skeleton/index.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d106a83...85d5aa0. Read the comment docs.

@darqs darqs changed the title Update to Electron 7.1.8 Small improvements Jan 11, 2020
@KoenLav
Copy link
Contributor

KoenLav commented Jan 16, 2020

We were experiencing problems with Meteor Desktop and Electron 7 due to this issue: electron/electron#21018

It should be resolved in Electron 7.1.10.

@darqs
Copy link
Collaborator Author

darqs commented Feb 14, 2020

Problem fixed in Electron 7.1.10

@darqs darqs closed this Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants