Skip to content

Commit

Permalink
test: disable demo project tests
Browse files Browse the repository at this point in the history
otherwise, node 10 is broken on CI. see jsdom/jsdom#2961 for details.
  • Loading branch information
urish committed Aug 1, 2020
1 parent 29ac4f2 commit bd259ff
Show file tree
Hide file tree
Showing 3 changed files with 16 additions and 7 deletions.
18 changes: 16 additions & 2 deletions demo/src/task-scheduler.spec.ts
Original file line number Diff line number Diff line change
@@ -1,11 +1,25 @@
/**
* @jest-environment jsdom
* remove-me @jest-environment jsdom
*/
/// <reference lib="dom" />

import { MicroTaskScheduler } from './task-scheduler';

describe('task-scheduler', () => {
/*
* We're skipping this test due to JSDOM issue:
* https://github.com/jsdom/jsdom/issues/2961
*
* It should pass on Node >= 12.0, but since the core library
* is expected to run on Node >= 10.0, and this test only applies
* to the demo project, it's better disabling it for now than
* getting false negatives.
*
* When this test is eventually re-enabled, don't forget to remove
* the `remove-me` text at the top of this file to re-enable the
* loading of jsdom.
*/
// eslint-disable-next-line jest/no-disabled-tests
describe.skip('task-scheduler', () => {
let taskScheduler: MicroTaskScheduler;
let task: jest.Mock;

Expand Down
1 change: 0 additions & 1 deletion jest.config.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
module.exports = {
preset: 'ts-jest',
testEnvironment: 'node',
setupFiles: ['./jsdom-workaround.js'],
globals: {
'ts-jest': {
tsConfig: 'tsconfig.spec.json',
Expand Down
4 changes: 0 additions & 4 deletions jsdom-workaround.js

This file was deleted.

0 comments on commit bd259ff

Please sign in to comment.