This repository has been archived by the owner on Feb 23, 2024. It is now read-only.
update to npm 7 #3434
Closed
update to npm 7 #3434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +6.92 kB (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
|
It seems we also need to force our actions to use npm 7 cc @nerrad do you have a pointer for this? |
|
For node we just have to remove this action in our workflows: For npm 7, since it's not lts, we'll probably just have to install it directly by adding the following to any workflows running npm install as a step: npm install -g npm@7 |
|
I updated that section to node 14. If we remove it, won't break our workflow? why did it add at first? |
I added it because github actions by default now install node 14 (because it's now LTS) and we weren't ready to update to node 14 yet :) |
|
You can make changes to the workflows in this pull only. |
|
This PR has been marked as If deemed still relevant, the pr can be kept active by ensuring it's up to date with the main branch and removing the stale label - otherwise it will automatically be closed after 10 days. |
github-actions
bot
added
the
status: stale
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates npm to 7 so we can use workspaces.
I also updated a couple of dependencies to bypass some errors.
I can't run e2e locally due to
nodegitnot being available, so I'm testing here.Will add more testing instruction once I get e2e to work.
What works
npm install.npm run build.npm start.npm run test.npm run test:e2e.npm run wp-env.