Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

Set eslint version back to 6.1.0 #896

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Set eslint version back to 6.1.0 #896

merged 1 commit into from
Aug 21, 2019

Conversation

Aljullu
Copy link
Contributor

@Aljullu Aljullu commented Aug 21, 2019

There seems to be a bug when updating eslint to 6.2.0 when it's used in combination with babel-eslint:

eslint/eslint#12117

babel/babel-eslint#791

Until there is an upstream fix, we should lock eslint version to 6.1.0.

How to test the changes in this Pull Request:

  1. Run npm run lint and see it pass.
  2. Verify Travis is passing in this PR.

@Aljullu Aljullu self-assigned this Aug 21, 2019
@Aljullu Aljullu added this to the 2.4 milestone Aug 21, 2019
@Aljullu Aljullu added the skip-changelog PRs that you don't want to appear in the changelog. label Aug 21, 2019
@Aljullu Aljullu added this to In Progress PRs (for automation purposes) in Isotope via automation Aug 21, 2019
@Aljullu Aljullu requested a review from a team August 21, 2019 11:22
Copy link
Member

@mikejolley mikejolley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mikejolley mikejolley merged commit 6fbf2df into master Aug 21, 2019
Isotope automation moved this from In Progress PRs (for automation purposes) to Done Sprint 23 (August 13 - August 26) Aug 21, 2019
@mikejolley mikejolley deleted the fix/travis-failures branch August 21, 2019 11:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
skip-changelog PRs that you don't want to appear in the changelog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants